Re: [PATCHv5] Add Gitweb support for XZ compressed snapshots

[demerphq <demerphq@gmail.com>]

2009/8/3 Jakub Narebski <jnareb@gmail.com>:
> On Sat, 1 Aug 2009, demerphq wrote:
>> 2009/8/1 Jakub Narebski <jnareb@gmail.com>:
>>> demerphq <demerphq@gmail.com> writes:
>>>
>>>> FWIW the perl project ripped out all the snapshot generation logic
>>>> from gitweb, and replaced it with a tool that generates snapshots
>>>> correctly for our requirements (if the build process needs additional
>>>> files /currently/ git-archive does not support adding them), this
>>>> includes a disk level cache for the snapshots since creating the tar,
>>>> adding the additional files, then gziping is quite slow.
>>>>
>>>> If its interesting to people I can post it and the other changes here,
>>>> although its not a "nice" change, as I literally ripped out the
>>>> existing code.
>>>
>>> Do you mean gitweb serving http://perl5.git.perl.org/ ?
>>
>> Yes. I updated it to a relatively recent version just the other week.
>
> By the way, if you don't mind, how do you keep your changes on top
> of changing target, i.e. on top of updating baseline to recent
> versions?

Things broke. I fixed them. :-)


>> Also probably there are one or two patches that should be pushed back
>> to you.
>
> What do those patches consist of?

One has to do with layout problems in the blame, and I think one deals
with broken line number anchor links.

Ill look closer when i have more time.

> By the way, this is one of the only two places where we have to
> use quote_command and 3-argument form of open, instead of list for of
> magic open.  It is because of pipeline, piping git-archive output
> into compressor.  The other such place is git_object, to redirect error
> stream to /dev/null (to discard stderr).
>
> I thought about replacing it by list form of open somewhat (you can
> find it in git mailing list archive), but it is not easy.  And IPC::Run
> is IMVHO a bit of overkill, especially for "minimal dependencies"
> gitweb (perhaps for Git::Web?).

Lately I have been playing with Capture::Tiny, which seems to fill
some nice niches in this respect.

>> A better git api toolset for perl would make things a lot easier.
>> Especially an XS one.
>
> Well, in the beginnings of Git.pm there was XS interface (to
> git-hash-object or git-cat-file), but it was dropped because it
> used -fPIC, which is not portable enough for Git (this is not present
> in perl/Git.pm history in git.git repository).  Git.pm was created
> by Petr 'Pasky' Baudis, author of Cogito porcelain, and creator and
> admin of repo.or.cz (and also creator of first Git homepage).
> But he is not a Perl hacker (correct me if I am wrong, Pasky); both
> Cogito and repo.or.cz duct tape (under name of Girocco) are written
> in bash, not in Perl.  Which can be seen for example by using
> Error::Simple in Git.pm...
>
> Also I don't think that Pasky has time for maintaining Git.pm,
> nevermind modernizing it / adding new features.
>
> There was another attempt to make Perl interface for Git, more
> object-oriented, by Lea Wiemann during GSoC 2008 project 'gitweb caching'.
> You can see results in Lea repository at repo.or.cz[1], and also in
> git.kernel.org gitweb code[2].
>
> [1]: http://repo.or.cz/w/git/gitweb-caching.git
> [2]: http://git.kernel.org/?p=git/warthog9/gitweb.git

Yeah I recall that being discussed. I see that Git.pm has recevied
some attention since the last time I looked. Which is good to see.

Having lurked on the list I understand that there is some kind of
effort for a git library.  Perhaps at some point that will end up with
an XS interface.

>>>
>>> P.P.S. Could you per chance post announcement of Git User's Survey 2009
>>> on http://perl5.git.perl.org, just like it is done on http://repo.or.cz
>>> and http://git.kernel.org?  TIA.
>>
>> Sure.
>
> Hmmm... I don't see "Git User's Survey 2009" announcement at
> http://perl5.git.perl.org/.  Neither at Planet Perl Iron Man, nor at
> Perlsphere

Ah, sorry, I posted it to the perl5-porters mailing list and asked the
relevant people to forward the request on or post it on their site. I
know at least one perl committer already did it. However tomorrow the
main european perl conference starts (YAPC::EU in Lisbon) and I think
a big chunk of the "active" Perl community will be there, so probably
there wont be much action from them until they get back.

To be honest I'm not familiar with Planet Perl Iron Man nor
Perlsphere. Ill have to check them out i guess. :-)

I will try to remember to put up a note on the website as soon as possible.

cheers,
Yves

-- 
perl -Mre=debug -e "/just|another|perl|hacker/"