git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: demerphq <demerphq@gmail.com>
To: Nicolas Pitre <nico@fluxnic.net>
Cc: "Shawn O. Pearce" <spearce@spearce.org>, git <git@vger.kernel.org>
Subject: Re: extra headers in commit objects
Date: Wed, 3 Feb 2010 20:01:17 +0100	[thread overview]
Message-ID: <9b18b3111002031101p3385ecdfo638433bc269791aa@mail.gmail.com> (raw)
In-Reply-To: <alpine.LFD.2.00.1002031311010.1681@xanadu.home>

On 3 February 2010 19:15, Nicolas Pitre <nico@fluxnic.net> wrote:
> On Wed, 3 Feb 2010, Shawn O. Pearce wrote:
>
>> Am I correct that core C developers are still under the opinion
>> that extra headers in a commit object aren't encouraged?
>
> I would say so.
>
> [...]
>> At the end of the day, is it a bug that C git doesn't support
>> working with extra commit headers?  IMHO, no, because, we've
>> rejected these in the past, and its not part of the Git standard.
>> And other implementations shouldn't be trying to sell it that way.
>
> Agreed.  And this was discussed in great length on this list on few
> occasions already (probably more than a year back).

One problem, is that if you take the approach you say then you
basically guarantee that a new git that DOES add new headers will
break an old git that doesnt know about the headers, and actually
doesnt care about them either.

So it would essentially mean that if you ever have to change the
commit format you will be in a position where new git commits will be
incompatible by design with old git commits.

Maybe I misunderstand, but this doesnt seem to accord with my reading
of the original design objectives and philosophy of git.

Shouldn't an old git just ignore headers from a new git?

I mean, forget about the fact that somebody is doing something naughty
with the git protocol, ask youself if you want this rule to basically
prevent any backwards compatible changes with older gits.

As a lurker here I understand completely if you ignore this mail
entirely. But this seems to me to be a decision that could bite you
later.

cheers,
Yves





-- 
perl -Mre=debug -e "/just|another|perl|hacker/"

  reply	other threads:[~2010-02-03 19:01 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-02-03 17:40 extra headers in commit objects Shawn O. Pearce
2010-02-03 18:15 ` Nicolas Pitre
2010-02-03 19:01   ` demerphq [this message]
2010-02-03 19:26     ` Shawn O. Pearce
2010-02-03 19:40       ` demerphq
2010-02-03 20:42       ` Junio C Hamano
2010-02-03 21:04         ` Shawn O. Pearce
2010-02-04  0:38           ` Junio C Hamano
2010-02-04  0:41       ` A Large Angry SCM
2010-02-03 19:26     ` Petr Baudis
2010-02-03 19:43       ` demerphq
2010-02-03 20:31         ` Shawn O. Pearce
2010-02-03 20:03       ` Nicolas Pitre
2010-02-03 19:53 ` Sverre Rabbelier
2010-02-03 19:58 ` Scott Chacon
2010-02-03 22:48   ` Shawn O. Pearce
2010-02-04  6:24     ` Mike Hommey
2010-02-03 20:58 ` Jelmer Vernooij
2010-02-03 21:17   ` Nicolas Pitre
2010-02-03 22:39   ` Shawn O. Pearce

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9b18b3111002031101p3385ecdfo638433bc269791aa@mail.gmail.com \
    --to=demerphq@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=nico@fluxnic.net \
    --cc=spearce@spearce.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).