From: Michael J Gruber <git@drmicha.warpmail.net>
To: git@vger.kernel.org
Cc: Junio C Hamano <gitster@pobox.com>, Jeff King <peff@peff.net>
Subject: [PATCH] t/lib-gpg: adjust permissions for gnupg 2.1
Date: Tue, 2 Dec 2014 14:40:27 +0100 [thread overview]
Message-ID: <9c28f16c677bbc774e5b8dfc79b6ffe2c55d1720.1417527514.git.git@drmicha.warpmail.net> (raw)
In-Reply-To: <547DB6C3.5010704@drmicha.warpmail.net>
Before gnupg 2.1 (aka "modern branch"), gpghome would contain only files
which allowed t/lib-gpg.sh to set permissions explicitely, and we did
that since
28a1b07 (t/lib-gpg: adjust permissions for gnupg 2.1, 2014-12-02)
in order to adjust wrong permissions from a checkout on ro file systems.
gnupg 2.1 creates a new directory in gpghome which would get its x bit removed.
Adjust and use +X so that any directory would get its x bit set. This
also keeps the x bit on files which had it set for whatever wrong
reason, but we care only about having at least the necessary
permissions for the tests to run.
Signed-off-by: Michael J Gruber <git@drmicha.warpmail.net>
---
Something like this?
Untested for lack of gpg2.1
t/lib-gpg.sh | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/t/lib-gpg.sh b/t/lib-gpg.sh
index cd2baef..25ca12d 100755
--- a/t/lib-gpg.sh
+++ b/t/lib-gpg.sh
@@ -17,8 +17,7 @@ else
# Name and email: C O Mitter <committer@example.com>
# No password given, to enable non-interactive operation.
cp -R "$TEST_DIRECTORY"/lib-gpg ./gpghome
- chmod 0700 gpghome
- chmod 0600 gpghome/*
+ chmod -R u+rwX gpghome
GNUPGHOME="$(pwd)/gpghome"
export GNUPGHOME
test_set_prereq GPG
--
2.2.0.rc3.286.g888a711
next prev parent reply other threads:[~2014-12-02 13:40 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-26 23:09 [ANNOUNCE] Git v2.2.0 Junio C Hamano
2014-11-27 21:32 ` Steven Noonan
2014-11-28 4:46 ` Jeff King
2014-11-28 9:48 ` Michael J Gruber
2014-11-28 16:50 ` tests do not work with gpg 2.1 Jeff King
2014-12-02 12:55 ` Michael J Gruber
2014-12-02 13:40 ` Michael J Gruber [this message]
2014-12-02 21:07 ` [PATCH] t/lib-gpg: adjust permissions for gnupg 2.1 Jeff King
2014-12-02 23:57 ` Junio C Hamano
2014-12-03 0:05 ` Jeff King
2014-12-03 16:21 ` Junio C Hamano
2014-12-03 11:23 ` Michael J Gruber
2014-12-03 16:45 ` Junio C Hamano
2014-12-02 21:21 ` tests do not work with gpg 2.1 Jeff King
2014-12-02 21:30 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9c28f16c677bbc774e5b8dfc79b6ffe2c55d1720.1417527514.git.git@drmicha.warpmail.net \
--to=git@drmicha.warpmail.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).