Git development
 help / color / mirror / Atom feed
From: "Julia Evans" <julia@jvns.ca>
To: "Junio C Hamano" <gitster@pobox.com>,
	"Julia Evans" <gitgitgadget@gmail.com>
Cc: git@vger.kernel.org, "D. Ben Knoble" <ben.knoble@gmail.com>,
	"Tuomas Ahola" <taahol@utu.fi>,
	"Richard Kerry" <richard.kerry@atos.ai>
Subject: Re: [PATCH v4 1/2] doc: remove gittutorial
Date: Fri, 30 Oct 2026 16:52:01 -0400	[thread overview]
Message-ID: <9e07da3c-0e75-41d2-8769-1347b3827ba6@app.fastmail.com> (raw)
In-Reply-To: <xmqqh5i5aemi.fsf@gitster.g>



On Wed, Oct 28, 2026, at 2:01 PM, Junio C Hamano wrote:
> "Julia Evans via GitGitGadget" <gitgitgadget@gmail.com> writes:
>
>> From: Julia Evans <julia@jvns.ca>
>>
>> The next commit replaces it with a new tutorial.
>>
>> Do this as a remove/add instead of just replacing the file in a single
>> commit to make the patches easier to read on the mailing list, since the
>> existing content isn't being reused.
>>
>> Signed-off-by: Julia Evans <julia@jvns.ca>
>> ---
>>  Documentation/gittutorial.adoc | 671 ---------------------------------
>>  1 file changed, 671 deletions(-)
>>  delete mode 100644 Documentation/gittutorial.adoc
>
> Strictly speaking, this step alone would break "make check-docs"
> because it fails to remove the reference to the removed document
> that is in Documentation/git.adoc file.  To be peanticly correct,
> this step must remove the reference from there, and then the next
> step must add it back, to make sure each and every step of the patch
> series builds and tests correctly.
>
> $ make check-docs
> ...
>     LINT GITLINK git.adoc
> git.adoc:1211: error: gittutorial[7]: link outside of our own docs, 
> shown with 'HERE' below:
> git.adoc:1211:  'linkgit:gittutorial[7]' <-- HERE
>
> I personally am too busy to worry about the "each and every step
> must correctly build and test" rule while flipping 100+ topics in
> 'seen' myself, so I'll update this topic in 'seen' as-is, but if we
> ever need rerolling this series, then we may want to remember
> cleaning it up.

I tried to fix this, but there are quite a few references to the tutorial
(including in `git.adoc`) and removing all of them would
cause some merge conflicts which I believe would cause more
work for you. I can remove them if you think that's best though.

> Having said all that, it seems to me that this version is now in a
> pretty good shape to be merged to 'next'?
>
> Thanks.

  reply	other threads:[~2026-10-30 20:52 UTC|newest]

Thread overview: 53+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-06 19:37 [PATCH 0/2] WIP: doc: add new git tutorial Julia Evans via GitGitGadget
2026-10-06 19:37 ` [PATCH 1/2] doc: remove gittutorial Julia Evans via GitGitGadget
2026-10-06 19:37 ` [PATCH 2/2] doc: add new Git tutorial for beginners Julia Evans via GitGitGadget
2026-10-07 19:48   ` D. Ben Knoble
2026-10-19 14:24     ` Julia Evans
2026-10-19 16:49       ` Ben Knoble
2026-10-19 20:42         ` Julia Evans
2026-10-19 21:14           ` D. Ben Knoble
2026-10-20 17:11   ` Junio C Hamano
2026-10-20 17:59     ` Julia Evans
2026-10-20 18:26       ` Junio C Hamano
2026-10-20 18:27       ` Junio C Hamano
2026-10-20 18:45         ` Junio C Hamano
2026-10-20 19:13           ` Junio C Hamano
2026-10-21 17:16             ` Junio C Hamano
2026-10-21 21:24               ` Julia Evans
2026-10-20 18:22     ` Julia Evans
2026-10-20 18:30       ` Junio C Hamano
2026-10-26 16:03       ` Richard Kerry
2026-10-26 19:14         ` Julia Evans
2026-10-26 20:03           ` Julia Evans
2026-10-26 20:17           ` Junio C Hamano
2026-10-26 20:22             ` Julia Evans
2026-10-26 20:54               ` Junio C Hamano
2026-10-07 19:26 ` [PATCH 0/2] WIP: doc: add new git tutorial D. Ben Knoble
2026-10-19 14:55 ` [PATCH v2 0/2] " Julia Evans via GitGitGadget
2026-10-19 14:55   ` [PATCH v2 1/2] doc: remove gittutorial Julia Evans via GitGitGadget
2026-10-19 14:55   ` [PATCH v2 2/2] doc: add new Git tutorial for beginners Julia Evans via GitGitGadget
2026-10-20  1:24   ` [PATCH v2 0/2] doc: add new git tutorial Junio C Hamano
2026-10-20  2:24     ` Ben Knoble
2026-10-20 12:18       ` Julia Evans
2026-10-20 18:50         ` Tuomas Ahola
2026-10-20 19:13     ` Junio C Hamano
2026-10-23 15:17 ` [PATCH v3 " Julia Evans via GitGitGadget
2026-10-23 15:17   ` [PATCH v3 1/2] doc: remove gittutorial Julia Evans via GitGitGadget
2026-10-23 15:17   ` [PATCH v3 2/2] doc: add new Git tutorial for beginners Julia Evans via GitGitGadget
2026-10-23 18:01   ` [PATCH v3 0/2] doc: add new git tutorial Ben Knoble
2026-10-27 14:30     ` Julia Evans
2026-10-27 15:19       ` Ben Knoble
2026-10-27 18:31         ` Julia Evans
2026-10-28 14:44 ` [PATCH v4 " Julia Evans via GitGitGadget
2026-10-28 14:44   ` [PATCH v4 1/2] doc: remove gittutorial Julia Evans via GitGitGadget
2026-10-28 18:01     ` Junio C Hamano
2026-10-30 20:52       ` Julia Evans [this message]
2026-10-30 22:27         ` Junio C Hamano
2026-10-28 14:44   ` [PATCH v4 2/2] doc: add new Git tutorial for beginners Julia Evans via GitGitGadget
2026-10-28 17:26     ` Junio C Hamano
2026-10-30 20:35       ` Julia Evans
2026-10-30 21:16         ` Junio C Hamano
2026-10-30 21:25           ` Junio C Hamano
2026-10-30 20:56 ` [PATCH v5 0/2] doc: add new git tutorial Julia Evans via GitGitGadget
2026-10-30 20:56   ` [PATCH v5 1/2] doc: remove gittutorial Julia Evans via GitGitGadget
2026-10-30 20:56   ` [PATCH v5 2/2] doc: add new Git tutorial for beginners Julia Evans via GitGitGadget

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9e07da3c-0e75-41d2-8769-1347b3827ba6@app.fastmail.com \
    --to=julia@jvns.ca \
    --cc=ben.knoble@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitgitgadget@gmail.com \
    --cc=gitster@pobox.com \
    --cc=richard.kerry@atos.ai \
    --cc=taahol@utu.fi \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox