short log and email address

short log and email address

[Jon Smirl]

Using the -e option in shortlog changes the results by spitting things
out by email address instead of leaving them combined  by name. That's
probably not what you want. Instead you want everything combined by
name and then display the most recent email address used.

Is there some way to fix this for the future? Maybe use Reply-to:
instead of From: on email import?

   998	David S. Miller <davem@sunset.davemloft.net>
   689	David S. Miller <davem@davemloft.net>
      6	David S. Miller <davem@huronp11.davemloft.net>
      5	David S. Miller <davem@hutch.davemloft.net>
      4	David S. Miller <davem@bnsf.davemloft.net>
      2	David S. Miller <davem@t1000.davemloft.net>
      2	David S. Miller <davem@ultra5.davemloft.net>
      1	David S. Miller <davem@goma.davemloft.net>


-- 
Jon Smirl
jonsmirl@gmail.com

Re: short log and email address

[Mark Brown]

On Mon, Jul 28, 2008 at 02:06:06PM -0400, Jon Smirl wrote:
> Using the -e option in shortlog changes the results by spitting things
> out by email address instead of leaving them combined  by name. That's
> probably not what you want. Instead you want everything combined by
> name and then display the most recent email address used.

Apart from anything else you're assuming that people's names are
globally unique - they aren't.  I'm aware of several Mark Browns active
in the free software world, for example.

-- 
"You grabbed my hand and we fell into it, like a daydream - or a fever."

Re: short log and email address

[Jon Smirl]

On 7/28/08, Mark Brown <broonie@sirena.org.uk> wrote:
> On Mon, Jul 28, 2008 at 02:06:06PM -0400, Jon Smirl wrote:
>  > Using the -e option in shortlog changes the results by spitting things
>  > out by email address instead of leaving them combined  by name. That's
>  > probably not what you want. Instead you want everything combined by
>  > name and then display the most recent email address used.
>
> Apart from anything else you're assuming that people's names are
>  globally unique - they aren't.  I'm aware of several Mark Browns active
>  in the free software world, for example.

There is a conflicting problem, multiple people with the same name and
people using multiple email addresses. The only solution I can see is
for the Mark Brown developers to get together and come up with a way
to differentiate their signatures (initial, nickname, etc), otherwise
I can't tell them apart from someone using multiple email addresses.

Mark Brown <broonie@opensource.wolfsonmicro.com>
Mark Brown <broonie@sirena.org.uk>

Same or two different people? These two names have committed to the kernel.

-- 
Jon Smirl
jonsmirl@gmail.com

Re: short log and email address

[Mark Brown]

On Mon, Jul 28, 2008 at 02:25:23PM -0400, Jon Smirl wrote:

> I can't tell them apart from someone using multiple email addresses.

> Mark Brown <broonie@opensource.wolfsonmicro.com>
> Mark Brown <broonie@sirena.org.uk>

> Same or two different people? These two names have committed to the kernel.

Both of them are me, though I have deliberately chosen to use the two
addresses (except for the stuff that went via ARM where the patch system
has the same inability to cope with multiple people with the same name).

-- 
"You grabbed my hand and we fell into it, like a daydream - or a fever."

Re: short log and email address

[Johannes Schindelin]

Hi,

On Mon, 28 Jul 2008, Jon Smirl wrote:

> Using the -e option in shortlog changes the results by spitting things 
> out by email address instead of leaving them combined by name. That's 
> probably not what you want. Instead you want everything combined by name 
> and then display the most recent email address used.

What is so wrong with _not_ using -e (since you do not want to see the 
email address stored in the commit message, and -e would be asking for 
that _exactly_)?

After the fact, you can annotate the names with all you like.  For 
example, the most recent email address for that person.

But as Mark pointed out, the name might be a bad key.  Maybe you will have 
to do something completely different, namely maintain a separate list of 
(correct) names and emails, and then having line numbers in .mailmap, 
like:

1 <davem@sunset>
1 <davem@sunrise>
1 <davem@moonshine>
2 <dave.miller@miller.com>
2 <dave.miller@highnoon.miller.com>

etc

However, I have to say that I see small value in that, and an inordinate 
amount of work that nobody wants to do.

Ciao,
Dscho

Re: short log and email address

[Jon Smirl]

On 7/28/08, Johannes Schindelin <Johannes.Schindelin@gmx.de> wrote:
> Hi,
>
>
>  On Mon, 28 Jul 2008, Jon Smirl wrote:
>
>  > Using the -e option in shortlog changes the results by spitting things
>  > out by email address instead of leaving them combined by name. That's
>  > probably not what you want. Instead you want everything combined by name
>  > and then display the most recent email address used.
>
>
> What is so wrong with _not_ using -e (since you do not want to see the
>  email address stored in the commit message, and -e would be asking for
>  that _exactly_)?

I wanted -e to give me the most recent email so that I would know how
to sort the mailmap alias list.

>
>  After the fact, you can annotate the names with all you like.  For
>  example, the most recent email address for that person.
>
>  But as Mark pointed out, the name might be a bad key.  Maybe you will have
>  to do something completely different, namely maintain a separate list of
>  (correct) names and emails, and then having line numbers in .mailmap,
>  like:
>
>  1 <davem@sunset>
>  1 <davem@sunrise>
>  1 <davem@moonshine>
>  2 <dave.miller@miller.com>
>  2 <dave.miller@highnoon.miller.com>
>
>  etc
>
>  However, I have to say that I see small value in that, and an inordinate
>  amount of work that nobody wants to do.

We could order the aliases until the correct alias is the last one. An
initial proxy would be to use the most recent email address on the
person's commits.

The trick is automating the maintenance.  Modify checkpatch,pl to look
up the person's name up in the mailmap file and retrieve all matching
aliases.

If the name isn't in mailmap, tell them to make a patch adding their
name or to change their name.

If the name is there but the email is not the last one in the list,
tell them to make a patch rearranging mailmap to reflect their current
name/email.

If name is there and email is last on list, don't complain.



>
>  Ciao,
>  Dscho
>
>


-- 
Jon Smirl
jonsmirl@gmail.com

Re: short log and email address

[Johannes Schindelin]

Hi,

On Mon, 28 Jul 2008, Jon Smirl wrote:

> On 7/28/08, Johannes Schindelin <Johannes.Schindelin@gmx.de> wrote:
>
> >  On Mon, 28 Jul 2008, Jon Smirl wrote:
> >
> >  > Using the -e option in shortlog changes the results by spitting 
> >  > things out by email address instead of leaving them combined by 
> >  > name. That's probably not what you want. Instead you want 
> >  > everything combined by name and then display the most recent email 
> >  > address used.
> >
> > What is so wrong with _not_ using -e (since you do not want to see the 
> > email address stored in the commit message, and -e would be asking for 
> > that _exactly_)?
> 
> I wanted -e to give me the most recent email so that I would know how
> to sort the mailmap alias list.

As I explained, that is not what -e is _supposed_ to do.  In Git, content 
is king, and as such -e should look at the content.  Unsurprisingly, that 
is exactly what it does.

Nothing prohibits you from post-processing the output, though.

Ciao,
Dscho

Re: short log and email address

[René Scharfe]

Jon Smirl schrieb:
> On 7/28/08, Johannes Schindelin <Johannes.Schindelin@gmx.de> wrote:
>> Hi,
>>
>>
>>  On Mon, 28 Jul 2008, Jon Smirl wrote:
>>
>>  > Using the -e option in shortlog changes the results by spitting things
>>  > out by email address instead of leaving them combined by name. That's
>>  > probably not what you want. Instead you want everything combined by name
>>  > and then display the most recent email address used.
>>
>>
>> What is so wrong with _not_ using -e (since you do not want to see the
>>  email address stored in the commit message, and -e would be asking for
>>  that _exactly_)?
> 
> I wanted -e to give me the most recent email so that I would know how
> to sort the mailmap alias list.

<snip>

> If the name isn't in mailmap, tell them to make a patch adding their
> name or to change their name.

That makes sense if you want to list all contributors in .mailmap...

> If the name is there but the email is not the last one in the list,
> tell them to make a patch rearranging mailmap to reflect their current
> name/email.

... but why would you want to check if they used their respective email
entry that is sorted last in the file?  A person might have multiple
current email addresses, e.g. someone could send patches for one
subsystem from work and patches for something else from home, as a hobby.

René