* [PATCH 6/9] update 'git-rm' bash completion according to the man page
@ 2009-08-08 8:56 Emmanuel Trillaud
2009-08-08 19:49 ` Junio C Hamano
0 siblings, 1 reply; 3+ messages in thread
From: Emmanuel Trillaud @ 2009-08-08 8:56 UTC (permalink / raw)
To: Shawn O. Pearce; +Cc: git
Signed-off-by: Emmanuel Trillaud <etrillaud@gmail.com>
---
contrib/completion/git-completion.bash | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/contrib/completion/git-completion.bash
b/contrib/completion/git-completion.bash
index 98e1185..4746eee 100755
--- a/contrib/completion/git-completion.bash
+++ b/contrib/completion/git-completion.bash
@@ -1828,7 +1828,7 @@ _git_rm ()
local cur="${COMP_WORDS[COMP_CWORD]}"
case "$cur" in
--*)
- __gitcomp "--cached --dry-run --ignore-unmatch --quiet"
+ __gitcomp "--force --cached --dry-run --ignore-unmatch --quiet"
return
;;
esac
--
1.6.4
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH 6/9] update 'git-rm' bash completion according to the man page
2009-08-08 8:56 [PATCH 6/9] update 'git-rm' bash completion according to the man page Emmanuel Trillaud
@ 2009-08-08 19:49 ` Junio C Hamano
2009-08-08 20:33 ` Emmanuel Trillaud
0 siblings, 1 reply; 3+ messages in thread
From: Junio C Hamano @ 2009-08-08 19:49 UTC (permalink / raw)
To: Emmanuel Trillaud; +Cc: Shawn O. Pearce, git
Emmanuel Trillaud <etrillaud@gmail.com> writes:
> Signed-off-by: Emmanuel Trillaud <etrillaud@gmail.com>
Description of what you did?
> - __gitcomp "--cached --dry-run --ignore-unmatch --quiet"
> + __gitcomp "--force --cached --dry-run --ignore-unmatch --quiet"
I thought not completing --force to allow a dangerous operation was a
conscious decision.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 6/9] update 'git-rm' bash completion according to the man page
2009-08-08 19:49 ` Junio C Hamano
@ 2009-08-08 20:33 ` Emmanuel Trillaud
0 siblings, 0 replies; 3+ messages in thread
From: Emmanuel Trillaud @ 2009-08-08 20:33 UTC (permalink / raw)
To: Junio C Hamano; +Cc: git
> > - __gitcomp "--cached --dry-run --ignore-unmatch
> > --quiet"
> > + __gitcomp "--force --cached --dry-run
> > --ignore-unmatch --quiet"
>
> I thought not completing --force to allow a dangerous operation was a
> conscious decision.
For me, completion as always been a reminder for options I forgot (or I
think they exist) and I use short options when I know them because it is
easier to type. So IMHO '--force' is a useful option that deserve to be
complete.
But if you make a conscious decision in the past to not complete
'--force', I won't fight :-) and I will just add a comment in the
git-completion script for the guys like me who think it is missing.
Best regard
Emmanuel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2009-08-08 20:38 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-08-08 8:56 [PATCH 6/9] update 'git-rm' bash completion according to the man page Emmanuel Trillaud
2009-08-08 19:49 ` Junio C Hamano
2009-08-08 20:33 ` Emmanuel Trillaud
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).