Git development
 help / color / mirror / Atom feed
From: Ben Knoble <ben.knoble@gmail.com>
To: phillip.wood@dunelm.org.uk
Cc: Jasper Mayone <me@jaspermayone.com>,
	kristofferhaugsbakk@fastmail.com, git@vger.kernel.org,
	gitster@pobox.com, sunshine@sunshineco.com,
	haraldnordgren@gmail.com
Subject: Re: [PATCH v2] worktree list: add --branch to select worktrees by branch
Date: Thu, 29 Oct 2026 10:23:39 -0400	[thread overview]
Message-ID: <A0B73028-E3BF-45CE-8468-AA9B022C41F6@gmail.com> (raw)
In-Reply-To: <d0051192-8e86-403d-9aae-b988883ccfd9@gmail.com>


> Le 29 oct. 2026 à 07:14, Phillip Wood <phillip.wood123@gmail.com> a écrit :
> 
> Hi Jasper
> 
>> On 29/10/2026 04:46, Jasper Mayone wrote:
> 
>> Is that change in behavior acceptable? A script that reads
>> %(worktreepath) would now get a path for a branch that is being
>> rebased. I think that is a fix, since the rest of Git already
>> considers that branch checked out, but I would like to hear if anyone
>> relies on the empty value.
> 
> I think we can consider the change in behavior to be a bug fix.

If we’re doing this in order to usefully feed it to worktree-remove, though,
do you really want to remove a worktree that is mid-rebase? I
would think that could have work you don’t want to throw away
without considering. (Besides which, would it show up
in --merged=origin? Hm.)

I suppose I would expect remove to fail without a « force » flag if
the worktree is mid-rebase, but still.

  reply	other threads:[~2026-10-29 14:23 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-21 17:33 [RFC PATCH 0/1] worktree list: add --merged and --no-merged Jasper Mayone
2026-10-21 17:33 ` [RFC PATCH 1/1] " Jasper Mayone
2026-10-23 18:30   ` Junio C Hamano
2026-10-24  6:25     ` Eric Sunshine
2026-10-24 16:53       ` [PATCH v2] worktree list: add --branch to select worktrees by branch Jasper Mayone
2026-10-25 14:47         ` Phillip Wood
2026-10-26 11:02           ` Phillip Wood
2026-10-28  6:02           ` Eric Sunshine
2026-10-28 15:27             ` Junio C Hamano
2026-10-28 11:32         ` Kristoffer Haugsbakk
2026-10-29  4:46           ` Jasper Mayone
2026-10-29  5:01             ` Eric Sunshine
2026-10-29 11:14             ` Phillip Wood
2026-10-29 14:23               ` Ben Knoble [this message]
2026-10-29 16:10                 ` Phillip Wood
2026-10-21 21:36 ` [RFC PATCH 0/1] worktree list: add --merged and --no-merged Harald Nordgren
2026-10-21 22:12   ` Junio C Hamano
2026-10-22  7:21     ` Harald Nordgren
2026-10-22 17:58   ` Kristoffer Haugsbakk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=A0B73028-E3BF-45CE-8468-AA9B022C41F6@gmail.com \
    --to=ben.knoble@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=haraldnordgren@gmail.com \
    --cc=kristofferhaugsbakk@fastmail.com \
    --cc=me@jaspermayone.com \
    --cc=phillip.wood@dunelm.org.uk \
    --cc=sunshine@sunshineco.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox