From: Thiago Farina <tfransosi@gmail.com>
To: Jonathan Nieder <jrnieder@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] Add test-string-list.c
Date: Tue, 7 Sep 2010 09:04:45 -0300 [thread overview]
Message-ID: <AANLkTi=1B6GaWZ0d6uiHWWjP7EvQLsaO0ZQDgWuBofDN@mail.gmail.com> (raw)
In-Reply-To: <20100907000703.GB32717@burratino>
On Mon, Sep 6, 2010 at 9:07 PM, Jonathan Nieder <jrnieder@gmail.com> wrote:
> Hi Thiago,
>
> Thiago Farina wrote:
>> On Sun, Sep 5, 2010 at 2:02 AM, Jonathan Nieder <jrnieder@gmail.com> wrote:>
>
>>> To make sure this example remains valid, wouldn't you want to include
>>> a caller in the t/ directory so it can be automatically run? (See
>>> t/README.)
>>
>> I read it, but I'm not sure how to do this. Maybe you could point me
>> to an example?
>
> t0070-fundamental.sh might be a good place to add it.
>
Thanks, added it to there.
>> It can be expanded later by anyone to test many other things though.
>
> I suppose. Edge cases for arguments, sorting, and _DUP versus _NODUP
> semantics would be the main thing I would be interested in testing.
Reworked into small functions to test string_list functions separated
(using assert to check if the return value of the function is what is
expected).
Please, take another look.
prev parent reply other threads:[~2010-09-07 12:04 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-05 2:34 [PATCH] Add test-string-list.c Thiago Farina
2010-09-05 5:02 ` Jonathan Nieder
2010-09-06 6:12 ` Junio C Hamano
2010-09-06 23:48 ` Thiago Farina
2010-09-07 0:07 ` Jonathan Nieder
2010-09-07 12:04 ` Thiago Farina [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='AANLkTi=1B6GaWZ0d6uiHWWjP7EvQLsaO0ZQDgWuBofDN@mail.gmail.com' \
--to=tfransosi@gmail.com \
--cc=git@vger.kernel.org \
--cc=jrnieder@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).