From: Chris Johnsen <chris_johnsen@pobox.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org,
Brandon Casey <brandon.casey.ctr@nrlssc.navy.mil>,
Brandon Casey <drafnel@gmail.com>,
Matthieu Moy <Matthieu.Moy@grenoble-inp.fr>
Subject: Re: [PATCH v2] git-rebase--interactive.sh: replace cut with ${v%% *}
Date: Sat, 18 Sep 2010 00:25:16 -0500 [thread overview]
Message-ID: <AANLkTi=9rDR0chmPrjK3eAKgg_ECbAjcUYhvP_GELdvc@mail.gmail.com> (raw)
In-Reply-To: <7v8w302fu1.fsf@alter.siamese.dyndns.org>
Junio C Hamano <gitster@pobox.com> wrote:
> Chris Johnsen <chris_johnsen@pobox.com> writes:
>> It seems like the other uses of cut in git-rebase--interactive.sh
>> would be more awkward if they were replaced with equivalent
>> processing done in-shell with parameter expansions...
>
> More importantly, they are fed output from rev-list and do not have
> breakage you observed on your Mac OS box, do they?
>
> IOW, I don't see anything that needs fixing in other uses.
Right, the other uses of cut do not cause any problems on my system.
Any remaining reason to change them would be along the lines of your
"the less of 'cut' we see, the better" and the possible efficency of
in-shell processing (e.g. for msys/cygwin).
--
Chris
prev parent reply other threads:[~2010-09-18 5:25 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-17 14:17 [PATCH] git-rebase--interactive.sh: LF terminate line sent to cut Chris Johnsen
2010-09-17 15:10 ` Brandon Casey
2010-09-17 18:38 ` Junio C Hamano
2010-09-17 18:59 ` Brandon Casey
2010-09-17 21:42 ` [PATCH v2] git-rebase--interactive.sh: replace cut with ${v%% *} Chris Johnsen
2010-09-17 21:57 ` Junio C Hamano
2010-09-18 5:25 ` Chris Johnsen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='AANLkTi=9rDR0chmPrjK3eAKgg_ECbAjcUYhvP_GELdvc@mail.gmail.com' \
--to=chris_johnsen@pobox.com \
--cc=Matthieu.Moy@grenoble-inp.fr \
--cc=brandon.casey.ctr@nrlssc.navy.mil \
--cc=drafnel@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).