From: Vitor Antunes <vitor.hda@gmail.com>
To: Pete Wyckoff <pw@padd.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 2/2] git-p4: Add copy detection support
Date: Sun, 6 Feb 2011 17:25:54 +0000 [thread overview]
Message-ID: <AANLkTi=Awi6d77QcbbZ2rDTv6LpP+qjsReJ5=4NyhUBz@mail.gmail.com> (raw)
In-Reply-To: <20110206002547.GB31245@arf.padd.com>
Hi Pete,
On Sun, Feb 6, 2011 at 12:25 AM, Pete Wyckoff <pw@padd.com> wrote:
> You can use integrate -t to force the filetype even if the file
> already existed, and skip the whole execbit change.
(Copying help text:
The -t flag makes the source file's filetype propagate to the target
file. Normally, the target file retains its previous filetype.
Newly branched files always use the source file's filetype. The
filetype can still be changed before 'p4 submit' with 'p4 reopen'.
)
Since in git we're only considering newly branched files, I think in
this case "-t" will not add anything. In fact, what is being done here
is detecting exec bit changes from source to target files - we're not
trying to force P4 to use the source's exec bit. Do you agree?
Kind regards,
--
Vitor Antunes
next prev parent reply other threads:[~2011-02-06 17:26 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-30 23:19 [PATCH 1/2] git-p4: Improve rename detection support Vitor Antunes
2011-01-30 23:19 ` [PATCH 2/2] git-p4: Add copy " Vitor Antunes
2011-02-06 0:25 ` Pete Wyckoff
2011-02-06 17:25 ` Vitor Antunes [this message]
2011-02-06 22:05 ` Pete Wyckoff
2011-02-07 11:11 ` Vitor Antunes
2011-02-12 0:29 ` Vitor Antunes
2011-02-12 13:32 ` Pete Wyckoff
2011-02-06 0:21 ` [PATCH 1/2] git-p4: Improve rename " Pete Wyckoff
2011-02-06 12:39 ` Vitor Antunes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='AANLkTi=Awi6d77QcbbZ2rDTv6LpP+qjsReJ5=4NyhUBz@mail.gmail.com' \
--to=vitor.hda@gmail.com \
--cc=git@vger.kernel.org \
--cc=pw@padd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).