From: Piotr Krukowiecki <piotr.krukowiecki@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Michal Rokos <rokos@nextsoft.cz>, GIT <git@vger.kernel.org>
Subject: Re: [PATCH] Honor HP C's noreturn attribute
Date: Tue, 8 Mar 2011 20:26:43 +0100 [thread overview]
Message-ID: <AANLkTi=FPkccc3Rk3YDuEsN3YGt_U1NhhT2MGHmbrAra@mail.gmail.com> (raw)
In-Reply-To: <7v4o7dfndw.fsf@alter.siamese.dyndns.org>
On Tue, Mar 8, 2011 at 8:00 PM, Junio C Hamano <gitster@pobox.com> wrote:
> Michal Rokos <rokos@nextsoft.cz> writes:
>
>> HP C for Integrity servers (Itanium) gained support for noreturn
>> attribute sometime in 2006. It was released in Compiler Version A.06.10
>> and made available in July 2006.
>>
>> The __HP_cc define detects the HP C compiler version. Precede the
>> __GNUC__ check so it works well when compiling with HP C using -Agcc
>> option that enables partial support for the GNU C dialect. The -Agcc
>> defines the __GNUC__ too.
>>
>> Signed-off-by: Michal Rokos <michal.rokos@nextsoft.cz>
>
> We tend to prefer new code be appended at the end of if/elif/.../then/fi
> cascade when there is no strong reason to do otherwise; your log message
> clearly explains why this particular #if needs to come before the existing
> one.
>
> I love it when people write a very readable log message to explain why the
> patch _has_ to be the way it is. Very good job.
I liked it too, but it'd be even better to put the comment in the code IMO.
I don't think anyone would check the commit to see if he can change the
order of the #ifdefs ...
(So please comment in code more!)
--
Piotr Krukowiecki
next prev parent reply other threads:[~2011-03-08 19:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-07 12:13 [PATCH] Honor HP C's noreturn attribute Michal Rokos
2011-03-08 19:00 ` Junio C Hamano
2011-03-08 19:26 ` Piotr Krukowiecki [this message]
2011-03-08 22:09 ` Michal Rokos
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='AANLkTi=FPkccc3Rk3YDuEsN3YGt_U1NhhT2MGHmbrAra@mail.gmail.com' \
--to=piotr.krukowiecki@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=rokos@nextsoft.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).