From: Nguyen Thai Ngoc Duy <pclouds@gmail.com>
To: Elijah Newren <newren@gmail.com>
Cc: git <git@vger.kernel.org>, gitster <gitster@pobox.com>
Subject: Re: [PATCH 2/7] Fix ignoring of pathspecs with rev-list --objects
Date: Fri, 27 Aug 2010 09:15:29 +1000 [thread overview]
Message-ID: <AANLkTi=Y5tbdxc4f2j_1D1gib2gwEzNw6_Az3Ag9T1nn@mail.gmail.com> (raw)
In-Reply-To: <AANLkTimCv-fn-h21pM8L9NiGg3w7OXBJ-kfiC+HJLsTP@mail.gmail.com>
On Thu, Aug 26, 2010 at 9:50 AM, Elijah Newren <newren@gmail.com> wrote:
>> While at it, can you please also fix its comments? The comments say
>> pathspec while what it uses is actually path prefix. Maybe something
>> like this
>>
>> diff --git a/tree-diff.c b/tree-diff.c
>> index 3c34c77..514dbca 100644
>> --- a/tree-diff.c
>> +++ b/tree-diff.c
>> @@ -83,7 +83,7 @@ static int compare_tree_entry(struct tree_desc *t1,
>> struct tree_desc *t2, const
>> }
>>
>> /*
>> - * Is a tree entry interesting given the pathspec we have?
>> + * Is a tree entry interesting given the path prefix we have?
>
> I believe the comment is parsed thus: "tree entry" == combination of
> desc, base, and baselen. "pathspec" == paths and pathlens fields of
> opt (which do provide a pathspec). So I believe the original was
> correct, though I can see how it's confusing at first.
Pathspec as in match_pathspec() in dir.c allows wildcards. Though it
seems only used with worktree or index-related operations. To me the
one with wildcard support is called pathspec. The one without is path
prefix. But it's probably just me.
There is also a GSoC suggestion about this [1] and I posted a related
patch a while back [2] but forgot it until now.
[1] https://git.wiki.kernel.org/index.php/SoC2010Ideas#Unify_Pathspec_Semantics
[2] http://mid.gmane.org/1243240924-5981-1-git-send-email-pclouds@gmail.com
--
Duy
next prev parent reply other threads:[~2010-08-26 23:15 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-25 2:53 [PATCH 0/7] Minor bug fix and optimizations for revision/tree walking Elijah Newren
2010-08-25 2:53 ` [PATCH 1/7] Add testcase showing how pathspecs are ignored with rev-list --objects Elijah Newren
2010-08-25 2:53 ` [PATCH 2/7] Fix ignoring of pathspecs " Elijah Newren
2010-08-25 22:11 ` Nguyen Thai Ngoc Duy
2010-08-25 23:50 ` Elijah Newren
2010-08-26 2:49 ` Elijah Newren
2010-08-26 23:15 ` Nguyen Thai Ngoc Duy [this message]
2010-08-26 23:41 ` Junio C Hamano
2010-08-25 2:53 ` [PATCH 3/7] tree-walk: Correct bitrotted comment about tree_entry() Elijah Newren
2010-08-25 2:53 ` [PATCH 4/7] tree_entry_interesting(): Make return value more specific Elijah Newren
2010-08-25 2:53 ` [PATCH 5/7] diff_tree(): Skip skip_uninteresting() when all remaining paths interesting Elijah Newren
2010-08-25 23:25 ` Junio C Hamano
2010-08-25 23:57 ` Elijah Newren
2010-08-26 3:49 ` Junio C Hamano
2010-08-25 2:53 ` [PATCH 6/7] list-objects.c: Avoid recomputing interesting-ness for subtrees when possible Elijah Newren
2010-08-25 2:53 ` [PATCH 7/7] tree-diff.c: " Elijah Newren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='AANLkTi=Y5tbdxc4f2j_1D1gib2gwEzNw6_Az3Ag9T1nn@mail.gmail.com' \
--to=pclouds@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=newren@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).