From: Erik Faye-Lund <kusmabite@gmail.com>
To: Jonathan Nieder <jrnieder@gmail.com>
Cc: git@vger.kernel.org, msysgit@googlegroups.com, j6t@kdbg.org,
gitster@pobox.com
Subject: Re: [RFC PATCH 5/6] msvc: opendir: handle paths ending with a slash
Date: Tue, 23 Nov 2010 18:47:51 +0100 [thread overview]
Message-ID: <AANLkTi=Yg2Dz7DgtixWBbvbUn_rrdJcgqMYiBqHFwosb@mail.gmail.com> (raw)
In-Reply-To: <20101123174351.GD12113@burratino>
On Tue, Nov 23, 2010 at 6:43 PM, Jonathan Nieder <jrnieder@gmail.com> wrote:
> Erik Faye-Lund wrote:
>
>> --- a/compat/msvc.c
>> +++ b/compat/msvc.c
>> @@ -23,6 +23,8 @@ DIR *opendir(const char *name)
>>
>> /* check that the pattern won't be too long for FindFirstFileA */
>> len = strlen(name);
>> + if (is_dir_sep(name[len - 1]))
>> + len--;
>
> I assume len can't be 0?
>
Nope, in that case GetFileAttributesA would have errore out.
next prev parent reply other threads:[~2010-11-23 17:48 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-23 17:30 [RFC PATCH 0/6] win32-dirent Erik Faye-Lund
2010-11-23 17:30 ` [RFC PATCH 1/6] msvc: opendir: use xmalloc Erik Faye-Lund
2010-11-23 17:40 ` Jonathan Nieder
2010-11-23 17:45 ` Erik Faye-Lund
2010-11-23 18:00 ` Erik Faye-Lund
2010-11-23 18:02 ` Jonathan Nieder
2010-11-23 18:12 ` Erik Faye-Lund
2010-11-23 17:30 ` [RFC PATCH 2/6] msvc: opendir: allocate enough memory Erik Faye-Lund
2010-11-23 17:42 ` Jonathan Nieder
2010-11-23 17:46 ` Erik Faye-Lund
2010-11-23 17:30 ` [RFC PATCH 3/6] msvc: opendir: do not start the search Erik Faye-Lund
2010-11-23 17:30 ` [RFC PATCH 4/6] win32: dirent: handle errors Erik Faye-Lund
2010-11-23 17:30 ` [RFC PATCH 5/6] msvc: opendir: handle paths ending with a slash Erik Faye-Lund
2010-11-23 17:43 ` Jonathan Nieder
2010-11-23 17:47 ` Erik Faye-Lund [this message]
2010-11-23 17:30 ` [RFC PATCH 6/6] win32: use our own dirent.h Erik Faye-Lund
2010-11-23 17:45 ` Jonathan Nieder
2010-11-23 17:51 ` Erik Faye-Lund
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='AANLkTi=Yg2Dz7DgtixWBbvbUn_rrdJcgqMYiBqHFwosb@mail.gmail.com' \
--to=kusmabite@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=j6t@kdbg.org \
--cc=jrnieder@gmail.com \
--cc=msysgit@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).