git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Sverre Rabbelier <srabbelier@gmail.com>
To: Ramana Kumar <ramana.kumar@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: inaccurate commit message message?
Date: Sat, 4 Sep 2010 18:07:52 -0500	[thread overview]
Message-ID: <AANLkTi=eK4qt7KLg7z-3vqV+hgUoW_xire6WftBJAYku@mail.gmail.com> (raw)
In-Reply-To: <AANLkTi=Vb2cQHPo388m9HYVdYkk3XC_-pM9bm182PWyf@mail.gmail.com>

Heya,

On Sat, Sep 4, 2010 at 17:55, Ramana Kumar <ramana.kumar@gmail.com> wrote:
> The documentation, both in man git-commit and in the commit message
> message, is misleading when you do git commit --verbose.

Correct.

> My proposal is to make it less misleading, by saying in at least one,
> and ideally both, of those places what you just told me for the first
> time: when you do a git commit --verbose, the diff lines and
> everything after will be ignored for the commit message.

Sounds like a good idea. See builtin/commit.c around line 660. You'll
want to check for the verbose flag and adjust the message printed
there accordingly. See Documentation/SubmittingPatches.txt on how to
submit patches.

Please do ask if you have any questions, I'd be glad to help.

-- 
Cheers,

Sverre Rabbelier

      reply	other threads:[~2010-09-04 23:08 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-09-04 21:37 inaccurate commit message message? Ramana Kumar
2010-09-04 21:55 ` Sverre Rabbelier
2010-09-04 22:55   ` Ramana Kumar
2010-09-04 23:07     ` Sverre Rabbelier [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='AANLkTi=eK4qt7KLg7z-3vqV+hgUoW_xire6WftBJAYku@mail.gmail.com' \
    --to=srabbelier@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=ramana.kumar@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).