From: "Øyvind A. Holm" <sunny@sunbase.org>
To: Jonathan Nieder <jrnieder@gmail.com>
Cc: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>
Subject: Re: 195b7ca6 breaks t9010 at current master
Date: Tue, 29 Mar 2011 15:37:10 +0200 [thread overview]
Message-ID: <AANLkTi=pDM2AXwLWtQQmp77dAzhooFSMXHtKAoN_S8_a@mail.gmail.com> (raw)
In-Reply-To: <20110329042446.GB25693@elie>
On 29 March 2011 06:24, Jonathan Nieder <jrnieder@gmail.com> wrote:
> Øyvind A. Holm wrote:
> > When running "make test" at current master (v1.7.4.2-406-gbe919d5),
> > t9010-svn-fe.sh fails. Bisecting shows that 195b7ca6 ("vcs-svn:
> > handle log message with embedded NUL") breaks the test.
>
> Could you try with the following patch applied? It comes from
> squashing the last two patches from the svn-fe branch:
>
> * tests: make sure input to sed is newline terminated
> * vcs-svn: add missing cast to printf argument
Thanks a lot. Yes, that works. It seems as it's "vcs-svn: add missing
cast to printf argument" that does the trick, at least t9010 doesn't
fail after that's applied. ... And it has reached the official master
now (as 8cc299d), seems it got pushed after I went to bed. I'm running a
test on current master (07514c8) now, and things look fine so far.
Regards,
Øyvind
next prev parent reply other threads:[~2011-03-29 13:37 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-29 2:08 195b7ca6 breaks t9010 at current master Øyvind A. Holm
2011-03-29 4:24 ` Jonathan Nieder
2011-03-29 7:06 ` Brian Gernhardt
2011-03-29 7:24 ` [PULL svn-fe] " Jonathan Nieder
2011-03-29 13:37 ` Øyvind A. Holm [this message]
2011-03-31 16:11 ` Brandon Casey
2011-03-31 21:14 ` Jonathan Nieder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='AANLkTi=pDM2AXwLWtQQmp77dAzhooFSMXHtKAoN_S8_a@mail.gmail.com' \
--to=sunny@sunbase.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jrnieder@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).