From: Dmitry Potapov <dpotapov@gmail.com>
To: Joey Hess <joey@kitenet.net>
Cc: git@vger.kernel.org, Jeff King <peff@peff.net>
Subject: Re: git subcommand sigint gotcha
Date: Tue, 19 Oct 2010 13:55:29 +0400 [thread overview]
Message-ID: <AANLkTi=tvyzyz2xpezufHLFc44HDbtMibkhNEvYxPB2g@mail.gmail.com> (raw)
In-Reply-To: <20101019045300.GA18043@gnu.kitenet.net>
On Tue, Oct 19, 2010 at 8:53 AM, Joey Hess <joey@kitenet.net> wrote:
> I was trying to write a git subcommand, and I noticed that if I ctrl-c'd
> it, git would return, but leave the subcommand running in the
> background.
It looks like this regression was introduced in v1.6.4, when Jeff tried to fix
one serious issue with a pager. I have bisected the problem to this commit:
http://git.kernel.org/?p=git/git.git;a=commit;h=d8e96fd86d415554a9c2e09ffb929a9e22fdad25
Dmitry
next prev parent reply other threads:[~2010-10-19 9:55 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-19 4:53 git subcommand sigint gotcha Joey Hess
2010-10-19 9:55 ` Dmitry Potapov [this message]
2010-10-19 11:59 ` RFC: [PATCH] ignore SIGINT&QUIT while waiting for external command Dmitry Potapov
2010-10-19 13:32 ` Jeff King
2010-10-19 13:40 ` Jeff King
2010-10-19 19:16 ` Jonathan Nieder
2010-10-19 19:50 ` Jeff King
2010-10-19 21:06 ` Jakub Narebski
2010-10-19 21:07 ` Jonathan Nieder
2010-10-19 16:31 ` Dmitry Potapov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='AANLkTi=tvyzyz2xpezufHLFc44HDbtMibkhNEvYxPB2g@mail.gmail.com' \
--to=dpotapov@gmail.com \
--cc=git@vger.kernel.org \
--cc=joey@kitenet.net \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).