git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Giuseppe Bilotta <giuseppe.bilotta@gmail.com>
To: git@vger.kernel.org
Cc: Junio C Hamano <gitster@pobox.com>,
	Giuseppe Bilotta <giuseppe.bilotta@gmail.com>
Subject: Re: [PATCH] git-web--browse: Add support for opera
Date: Sat, 27 Nov 2010 16:19:32 +0100	[thread overview]
Message-ID: <AANLkTik-PnsZ7tBEgLixoKOYYrytdOGfDocuMECGn-6O@mail.gmail.com> (raw)
In-Reply-To: <1290856558-6122-1-git-send-email-giuseppe.bilotta@gmail.com>

Actually, ignore this patch for the time being, I'm preparing a longer
set that includes it but might need some discussion. Sorry for the
noise.

On Sat, Nov 27, 2010 at 12:15 PM, Giuseppe Bilotta
<giuseppe.bilotta@gmail.com> wrote:
> It's probably not the most widespread browser, it's free as in gratis
> but not as in libre, but it's worth supporting regardless, especially
> since it's a trivial addition.
>
> Signed-off-by: Giuseppe Bilotta <giuseppe.bilotta@gmail.com>
> ---
>  git-web--browse.sh |    6 +++---
>  1 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/git-web--browse.sh b/git-web--browse.sh
> index 3fc4166..eb70375 100755
> --- a/git-web--browse.sh
> +++ b/git-web--browse.sh
> @@ -31,7 +31,7 @@ valid_custom_tool()
>
>  valid_tool() {
>        case "$1" in
> -               firefox | iceweasel | chrome | google-chrome | chromium | konqueror | w3m | links | lynx | dillo | open | start)
> +               firefox | iceweasel | chrome | google-chrome | chromium | konqueror | opera | w3m | links | lynx | dillo | open | start)
>                        ;; # happy
>                *)
>                        valid_custom_tool "$1" || return 1
> @@ -103,7 +103,7 @@ fi
>
>  if test -z "$browser" ; then
>     if test -n "$DISPLAY"; then
> -       browser_candidates="firefox iceweasel google-chrome chrome chromium konqueror w3m links lynx dillo"
> +       browser_candidates="firefox iceweasel google-chrome chrome chromium konqueror opera w3m links lynx dillo"
>        if test "$KDE_FULL_SESSION" = "true"; then
>            browser_candidates="konqueror $browser_candidates"
>        fi
> @@ -173,7 +173,7 @@ case "$browser" in
>     start)
>         exec "$browser_path" '"web-browse"' "$@"
>         ;;
> -    dillo)
> +    opera|dillo)
>        "$browser_path" "$@" &
>        ;;
>     *)
> --
> 1.7.3.2.184.gecaee
>
>



-- 
Giuseppe "Oblomov" Bilotta

      reply	other threads:[~2010-11-27 15:20 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-27 11:15 [PATCH] git-web--browse: Add support for opera Giuseppe Bilotta
2010-11-27 15:19 ` Giuseppe Bilotta [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=AANLkTik-PnsZ7tBEgLixoKOYYrytdOGfDocuMECGn-6O@mail.gmail.com \
    --to=giuseppe.bilotta@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).