From: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
To: Jonathan Nieder <jrnieder@gmail.com>
Cc: Brandon Casey <casey@nrlssc.navy.mil>,
git@vger.kernel.org, erick.mattos@gmail.com,
jaredhance@gmail.com, drafnel@gmail.com
Subject: Re: [PATCH] t/: work around one-shot variable assignment with test_must_fail
Date: Wed, 21 Jul 2010 00:09:13 +0000 [thread overview]
Message-ID: <AANLkTik0gKFfDCmcLZnn4WFCFY3Lb5zRgrzKLAgD5qH6@mail.gmail.com> (raw)
In-Reply-To: <20100721000101.GB4282@burratino>
On Wed, Jul 21, 2010 at 00:01, Jonathan Nieder <jrnieder@gmail.com> wrote:
> Ævar Arnfjörð Bjarmason wrote:
>
>> You must use "export PAGER;", not "export PAGER &&". export doesn't
>> return zero on all systems when exporting, see previous changes in
>> this regard in t/.
>
> Nope. Sorry I missed this before.
>
> diff --git a/t/README b/t/README
> index b906ceb..f81998b 100644
> --- a/t/README
> +++ b/t/README
> @@ -259,11 +259,11 @@ Do:
> test ...
>
> That way all of the commands in your tests will succeed or fail. If
> - you must ignore the return value of something (e.g. the return
> - value of export is unportable) it's best to indicate so explicitly
> - with a semicolon:
> + you must ignore the return value of something (e.g., the return
> + after unsetting a variable that was already unset is unportable) it's
> + best to indicate so explicitly with a semicolon:
We should have examples for both export and unset, but the prose
should mention both IMO
next prev parent reply other threads:[~2010-07-21 0:09 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-20 15:24 [PATCH] t/t3700: convert two uses of negation operator '!' to use test_must_fail Brandon Casey
2010-07-20 15:55 ` Ævar Arnfjörð Bjarmason
2010-07-20 16:32 ` Brandon Casey
2010-07-20 16:38 ` Jared Hance
2010-07-20 17:17 ` [PATCH] t/README: clarify test_must_fail description Brandon Casey
2010-07-20 18:00 ` Junio C Hamano
2010-07-20 18:06 ` Ævar Arnfjörð Bjarmason
2010-07-20 18:14 ` Jared Hance
2010-07-20 19:09 ` [PATCH] Convert "! git" to "test_must_fail" git Jared Hance
2010-07-20 19:42 ` Brandon Casey
2010-07-20 19:48 ` Jonathan Nieder
2010-07-20 19:59 ` Brandon Casey
2010-07-20 23:18 ` [PATCH v2] Convert "! git" to "test_must_fail git" Jared Hance
2010-07-20 18:34 ` [PATCH] t/README: clarify test_must_fail description Junio C Hamano
2010-07-20 18:43 ` Ævar Arnfjörð Bjarmason
2010-07-20 19:16 ` Jonathan Nieder
2010-07-20 20:49 ` Ævar Arnfjörð Bjarmason
2010-07-20 21:12 ` Brandon Casey
2010-07-20 21:25 ` Ævar Arnfjörð Bjarmason
2010-07-20 21:55 ` [PATCH] t/: work around one-shot variable assignment with test_must_fail Brandon Casey
2010-07-20 23:19 ` Erick Mattos
[not found] ` <20100721000823.GD4282@burratino>
[not found] ` <AANLkTinlXsbp0NdhmqvlrmBBqGuGOIkh6PzGYFnk05qv@mail.gmail.com>
[not found] ` <20100721141140.GA12123@burratino>
[not found] ` <AANLkTinhyFD4RhLLxS-jj-oX5VWqGyy7AiXJ3VJlcU2W@mail.gmail.com>
2010-07-21 15:23 ` [PATCH] gitweb: clarify search results page when no matching commit found Jonathan Nieder
2010-07-21 17:51 ` Jakub Narebski
2010-07-21 19:50 ` [PATCH v2] " Jonathan Nieder
2010-07-21 15:32 ` [PATCH] t/: work around one-shot variable assignment with test_must_fail Brandon Casey
2010-07-22 0:28 ` Erick Mattos
2010-07-20 23:44 ` Ævar Arnfjörð Bjarmason
2010-07-20 23:45 ` Ævar Arnfjörð Bjarmason
2010-07-21 0:01 ` Jonathan Nieder
2010-07-21 0:09 ` Ævar Arnfjörð Bjarmason [this message]
2010-07-21 0:14 ` Jonathan Nieder
2010-07-21 0:34 ` Ævar Arnfjörð Bjarmason
2010-07-21 1:05 ` git name-rev for fun and profit (Re: [PATCH] t/: work around one-shot variable assignment with test_must_fail) Jonathan Nieder
2010-07-21 11:32 ` Ævar Arnfjörð Bjarmason
2010-07-21 19:29 ` [PATCH] t/: work around one-shot variable assignment with test_must_fail Junio C Hamano
2010-07-22 0:32 ` Erick Mattos
2010-07-22 18:21 ` Brandon Casey
2010-07-20 18:19 ` [PATCH] t/README: clarify test_must_fail description Brandon Casey
2010-07-20 17:52 ` [PATCH] t/t3700: convert two uses of negation operator '!' to use test_must_fail Ævar Arnfjörð Bjarmason
2010-07-20 18:25 ` Ævar Arnfjörð Bjarmason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AANLkTik0gKFfDCmcLZnn4WFCFY3Lb5zRgrzKLAgD5qH6@mail.gmail.com \
--to=avarab@gmail.com \
--cc=casey@nrlssc.navy.mil \
--cc=drafnel@gmail.com \
--cc=erick.mattos@gmail.com \
--cc=git@vger.kernel.org \
--cc=jaredhance@gmail.com \
--cc=jrnieder@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).