git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
To: Brandon Casey <casey@nrlssc.navy.mil>
Cc: gitster@pobox.com, git@vger.kernel.org,
	Brandon Casey <drafnel@gmail.com>
Subject: Re: [PATCH] t/t9700/test.pl: don't access private object members, use  public access methods
Date: Tue, 29 Jun 2010 02:19:50 +0000	[thread overview]
Message-ID: <AANLkTik3L7VcjezVK_8PCKsSpNFaTfYNvsOAgckhv-6K@mail.gmail.com> (raw)
In-Reply-To: <OYRSzEHOHSti8exa5KJzWIUEyJ8xb2sfcvm4pUcvYhBXldZMw8JzP6a6cRcRRIZjiOtW9kzmnVA@cipher.nrlssc.navy.mil>

On Mon, Jun 28, 2010 at 22:51, Brandon Casey <casey@nrlssc.navy.mil> wrote:
> From: Brandon Casey <drafnel@gmail.com>
>
> This test is accessing private object members of the Test::More and
> Test::Builder objects.  Older versions of Test::More did not implement
> these variables using a hash.
>
> My system complains as follows:
>
>   Can't coerce array into hash at <snip>/t/t9700/test.pl line 13.
>   BEGIN failed--compilation aborted at <snip>/t/t9700/test.pl line 15.

Just for the record, what version of Test::More is that:

    perl -MTest::More -le 'print $Test::More::VERSION'

> There are public access methods available for retrieving and setting these
> variables, so let's use them instead.
>
> Signed-off-by: Brandon Casey <casey@nrlssc.navy.mil>

This looks good, sorry for the API mistake on my part.

Acked-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>

  reply	other threads:[~2010-06-29  2:21 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-06-28 22:51 [PATCH] t/t9700/test.pl: don't access private object members, use public access methods Brandon Casey
2010-06-29  2:19 ` Ævar Arnfjörð Bjarmason [this message]
2010-06-29 13:21   ` Brandon Casey
2010-06-29 16:33     ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=AANLkTik3L7VcjezVK_8PCKsSpNFaTfYNvsOAgckhv-6K@mail.gmail.com \
    --to=avarab@gmail.com \
    --cc=casey@nrlssc.navy.mil \
    --cc=drafnel@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).