From: Pat Notz <patnotz@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Ilari Liusvaara <ilari.liusvaara@elisanet.fi>, git@vger.kernel.org
Subject: Re: [RFC PATCH v5 0/3] git-remote-fd & git-remote-ext
Date: Fri, 8 Oct 2010 14:07:22 -0600 [thread overview]
Message-ID: <AANLkTik3SC5p2nvPMoj5-MWk0HnJ1WNTtEwPK4L8Hrae@mail.gmail.com> (raw)
In-Reply-To: <7vtykwv4os.fsf@alter.siamese.dyndns.org>
On Fri, Oct 8, 2010 at 1:56 PM, Junio C Hamano <gitster@pobox.com> wrote:
[snip]
> Could you fix these up at your end please?
>
> ERROR: space required before the open parenthesis '('
> #216: FILE: transport-helper.c:990:
> + while(t->state != SSTATE_FINISHED) {
>
[snip]
Please forgive my newness. What are you using to do the style check?
I'd love to run that myself, preferably in a pre-commit hook or
something. Maybe we can use astyle to help with this too.
Thanks ~ Pat
prev parent reply other threads:[~2010-10-08 20:07 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-08 18:39 [RFC PATCH v5 0/3] git-remote-fd & git-remote-ext Ilari Liusvaara
2010-10-08 18:39 ` [RFC PATCH v5 1/3] Add bidirectional_transfer_loop() Ilari Liusvaara
2010-10-08 18:39 ` [RFC PATCH v5 2/3] git-remote-fd Ilari Liusvaara
2010-10-08 18:40 ` [RFC PATCH v5 3/3] git-remote-ext Ilari Liusvaara
2010-10-08 19:56 ` [RFC PATCH v5 0/3] git-remote-fd & git-remote-ext Junio C Hamano
2010-10-08 20:07 ` Pat Notz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AANLkTik3SC5p2nvPMoj5-MWk0HnJ1WNTtEwPK4L8Hrae@mail.gmail.com \
--to=patnotz@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=ilari.liusvaara@elisanet.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).