From: Steven Walter <stevenrwalter@gmail.com>
To: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Cc: Eric Wong <normalperson@yhbt.net>, Sam Vilain <sam@vilain.net>,
git@vger.kernel.org
Subject: Re: [PATCH] Add unit test for check_cherry_pick
Date: Fri, 3 Sep 2010 15:26:09 -0400 [thread overview]
Message-ID: <AANLkTik5kcD1reuGfq4k_Oidkx00MY8E+Ucf+Ef_gCDD@mail.gmail.com> (raw)
In-Reply-To: <AANLkTikjGgzOxNz-Fepcg2ALqdWurzMyQUmRgqyxQN5L@mail.gmail.com>
On Fri, Sep 3, 2010 at 3:12 PM, Ævar Arnfjörð Bjarmason
<avarab@gmail.com> wrote:
> On Fri, Sep 3, 2010 at 18:52, Steven Walter <stevenrwalter@gmail.com> wrote:
>
>> +GIT_SVN_LC_ALL=${LC_ALL:-$LANG}
>
> What's this about?
>
>> +. ./lib-git-svn.sh
>> +
>> +say 'define NO_SVN_TESTS to skip git svn tests'
>> +
>> +case "$GIT_SVN_LC_ALL" in
>> +*.UTF-8)
>> + test_set_prereq UTF8
>
> You never use this prereq?
I'll admit that I copied these from t9100. I assumed they were
necessary for correct operation. If that's not the case, then they
can be removed.
--
-Steven Walter <stevenrwalter@gmail.com>
next prev parent reply other threads:[~2010-09-03 19:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <AANLkTikuY28wwccxekDXD1WGtaOoF3JG7ZBfm6vjapwt@mail.gmail.com>
2010-09-03 18:52 ` [PATCH] Add unit test for check_cherry_pick Steven Walter
2010-09-03 19:12 ` Ævar Arnfjörð Bjarmason
2010-09-03 19:26 ` Steven Walter [this message]
2010-09-03 20:48 ` Eric Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AANLkTik5kcD1reuGfq4k_Oidkx00MY8E+Ucf+Ef_gCDD@mail.gmail.com \
--to=stevenrwalter@gmail.com \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=normalperson@yhbt.net \
--cc=sam@vilain.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).