From: Linus Torvalds <torvalds@linux-foundation.org>
To: Jeff King <peff@peff.net>
Cc: Junio C Hamano <gitster@pobox.com>,
Martin Langhoff <martin.langhoff@gmail.com>,
Git Mailing List <git@vger.kernel.org>
Subject: Re: [RFC/PATCH 4/4] inexact rename detection eye candy
Date: Sat, 19 Feb 2011 07:57:57 -0800 [thread overview]
Message-ID: <AANLkTik=pd3vVMERz=H3sp835Ft8OvrOzBE4PUS7vrO7@mail.gmail.com> (raw)
In-Reply-To: <20110219102533.GD22508@sigill.intra.peff.net>
On Sat, Feb 19, 2011 at 2:25 AM, Jeff King <peff@peff.net> wrote:
>
> This feels wrong because it's in such a deep library function. At the
> very least we probably need some way to turn it off, so callers can pass
> along any --quiet or --no-progress indicators.
Yeah.
> I made it update progress for each of the rename_src * rename_dst
> similarity estimates. We could just as easily count rename_dst items we
> look at, but hey, it's eye candy, and obviously bigger numbers are
> better.
Uhh. My only big reaction to your patch was literally "why don't you
just do it on the 'dst' items". I really don't think bigger numbers
are better, and if you have _so_ many sources that each dst takes so
long that you'd want updates at that granularity, you're too screwed
anyway.
Don't make the "update progress" be part of the O(n^2) problem.
Linus
next prev parent reply other threads:[~2011-02-19 15:58 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-18 18:58 Merging limitations after directory renames -- interesting test repo Martin Langhoff
2011-02-18 22:21 ` Jeff King
2011-02-18 23:27 ` Linus Torvalds
2011-02-19 0:26 ` Linus Torvalds
2011-02-19 0:52 ` Junio C Hamano
2011-02-19 1:03 ` Linus Torvalds
2011-02-19 1:20 ` Linus Torvalds
2011-02-19 0:55 ` Linus Torvalds
2011-02-19 0:44 ` Junio C Hamano
2011-02-19 9:08 ` Jeff King
2011-02-19 10:19 ` Jeff King
2011-02-19 10:20 ` [PATCH 1/4] merge: improve inexact rename limit warning Jeff King
2011-02-21 23:33 ` Junio C Hamano
2011-02-22 15:39 ` Jeff King
2011-02-22 18:46 ` Junio C Hamano
2011-02-23 8:02 ` Jeff King
2011-02-19 10:21 ` [PATCH 2/4] bump rename limit defaults (again) Jeff King
2011-02-19 17:54 ` Piotr Krukowiecki
2011-02-20 10:10 ` Jeff King
2011-02-19 20:12 ` Ævar Arnfjörð Bjarmason
2011-02-20 10:12 ` Jeff King
2011-02-19 10:21 ` [PATCH 3/4] commit: stop setting rename limit Jeff King
2011-02-19 10:25 ` [RFC/PATCH 4/4] inexact rename detection eye candy Jeff King
2011-02-19 15:57 ` Linus Torvalds [this message]
2011-02-20 9:48 ` Jeff King
2011-02-20 9:51 ` [PATCH 1/3] add inexact rename detection progress infrastructure Jeff King
2011-02-20 9:53 ` [PATCH 2/3] merge: enable progress reporting for rename detection Jeff King
2011-02-20 9:56 ` [PATCH 3/3] pull: propagate --progress to merge Jeff King
2011-02-20 10:37 ` [RFC/PATCH 4/4] inexact rename detection eye candy Jeff King
2011-02-19 16:29 ` Martin Langhoff
2011-02-20 10:04 ` Jeff King
2011-02-20 13:16 ` Martin Langhoff
2011-02-19 15:22 ` Merging limitations after directory renames -- interesting test repo Martin Langhoff
2011-02-19 15:31 ` Martin Langhoff
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='AANLkTik=pd3vVMERz=H3sp835Ft8OvrOzBE4PUS7vrO7@mail.gmail.com' \
--to=torvalds@linux-foundation.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=martin.langhoff@gmail.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).