From: Nguyen Thai Ngoc Duy <pclouds@gmail.com>
To: Git Mailing List <git@vger.kernel.org>
Subject: [1.8.0] Support quoting in .gitattributes, .gitignore
Date: Thu, 3 Feb 2011 18:51:18 +0700 [thread overview]
Message-ID: <AANLkTikHNKmcapVWBAcufq8ONVWOWHbnL-H8Nf2WmKM5@mail.gmail.com> (raw)
Proposal:
There's already a patch for .gitattributes [1].
To summarize: .gitattributes separates pattern and attributes by
spaces, therefore spaces could not be present in patterns. There are
tricks to overcome (e.g. substitute spaces with dots) but it's well..
tricky. The patch adds support for quoting full patterns.
While .gitignore does not have the same problem, it'd be nice to
support quoting too for a few reasons:
- Keep differences between gitattr and gitignore to minimum. A
hero(ine) might come and unify them some day. Don't make his/her work
harder.
- Is ability to put \n in patterns counted as a good point?
Risks:
Current patterns with leading double quote mark will be
misinterpreted. Though chances are really small.
Migration plan:
I think a release note mentioning this is enough. No migration needed.
But to be safe, we can make post-1.7.5 warn users about patterns with
leading double quote. By 1.8.0, the new behavior will be used.
[1] http://article.gmane.org/gmane.comp.version-control.git/160867
--
Duy
next reply other threads:[~2011-02-03 11:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-03 11:51 Nguyen Thai Ngoc Duy [this message]
2011-02-03 19:03 ` [1.8.0] Support quoting in .gitattributes, .gitignore Junio C Hamano
2011-02-04 13:17 ` Nguyen Thai Ngoc Duy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AANLkTikHNKmcapVWBAcufq8ONVWOWHbnL-H8Nf2WmKM5@mail.gmail.com \
--to=pclouds@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).