From: Tay Ray Chuan <rctay89@gmail.com>
To: Jonathan Nieder <jrnieder@gmail.com>
Cc: Git Mailing List <git@vger.kernel.org>,
Junio C Hamano <gitster@pobox.com>,
Gabriel Corona <gabriel.corona@enst-bretagne.fr>
Subject: Re: [PATCH 5/6] http-push: check path length before using it
Date: Sat, 20 Nov 2010 12:28:51 +0800 [thread overview]
Message-ID: <AANLkTikJz+SigzqFdeP+rZR3FS06U1exDb59AsRFTQAj@mail.gmail.com> (raw)
In-Reply-To: <20101119183339.GB26187@burratino>
Hi,
On Sat, Nov 20, 2010 at 2:33 AM, Jonathan Nieder <jrnieder@gmail.com> wrote:
> [snip]
> ... or here. So perhaps:
>
> if (path) {
> const char *url = repo->path;
> if (!url)
> url = repo->url;
> if (strncmp(path, url, repo->path_len)) {
> error("Parsed path '%s' does not match url: '%s'\n",
> path, url);
> } else {
> path += ...
Looks much cleaner, thanks.
> By the way, is the error behavior correct? This prints a message with
> "error: " and then continues anyway.
Yeah, this fits in with the exiting xml code paths - they just
indicate errors and continue.
--
Cheers,
Ray Chuan
next prev parent reply other threads:[~2010-11-20 4:28 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-19 0:06 [PATCH] Normalise directory names when pushing to some WebDAV servers Gabriel Corona
2010-11-19 4:02 ` Tay Ray Chuan
2010-11-19 5:10 ` Jonathan Nieder
2010-11-19 12:46 ` [PATCH 0/6] http (dumb): end urls with slash Tay Ray Chuan
2010-11-19 12:46 ` [PATCH 1/6] shift end_url_with_slash() from http.[ch] to url.[ch] Tay Ray Chuan
2010-11-19 12:46 ` [PATCH 2/6] url: add str wrapper for end_url_with_slash() Tay Ray Chuan
2010-11-19 12:46 ` [PATCH 3/6] http-push: Normalise directory names when pushing to some WebDAV servers Tay Ray Chuan
2010-11-19 12:46 ` [PATCH 4/6] http-backend: use end_url_with_slash() Tay Ray Chuan
2010-11-19 12:46 ` [PATCH 5/6] http-push: check path length before using it Tay Ray Chuan
2010-11-19 12:46 ` [PATCH 6/6] http-push: add trailing slash at arg-parse time, instead of later on Tay Ray Chuan
2010-11-19 18:33 ` [PATCH 5/6] http-push: check path length before using it Jonathan Nieder
2010-11-20 4:28 ` Tay Ray Chuan [this message]
2010-11-19 19:18 ` [PATCH 0/6] http (dumb): end urls with slash Jonathan Nieder
2010-11-19 22:54 ` Junio C Hamano
2010-11-20 4:32 ` Tay Ray Chuan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AANLkTikJz+SigzqFdeP+rZR3FS06U1exDb59AsRFTQAj@mail.gmail.com \
--to=rctay89@gmail.com \
--cc=gabriel.corona@enst-bretagne.fr \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jrnieder@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).