From: Erik Faye-Lund <kusmabite@gmail.com>
To: Jonathan Nieder <jrnieder@gmail.com>
Cc: git@vger.kernel.org, msysgit@googlegroups.com, j6t@kdbg.org,
avarab@gmail.com, sunshine@sunshineco.com, schwab@linux-m68k.org,
patthoyts@gmail.com
Subject: Re: [PATCH 07/15] daemon: use run-command api for async serving
Date: Fri, 22 Oct 2010 02:20:09 +0200 [thread overview]
Message-ID: <AANLkTikL-uWKUtcB=NS+42ajAGrLH1B9CEE6B-0Ykeiq@mail.gmail.com> (raw)
In-Reply-To: <20101022001010.GB13779@burratino>
On Fri, Oct 22, 2010 at 2:10 AM, Jonathan Nieder <jrnieder@gmail.com> wrote:
> Erik Faye-Lund wrote:
>
>> --- a/daemon.c
>> +++ b/daemon.c
> [...]
>> @@ -671,18 +658,26 @@ static void check_dead_children(void)
>> int status;
>> pid_t pid;
>>
>> - while ((pid = waitpid(-1, &status, WNOHANG)) > 0) {
>> + struct child **cradle, *blanket;
>> + for (cradle = &firstborn; (blanket = *cradle);)
>> + if ((pid = waitpid(blanket->cld.pid, &status, WNOHANG)) > 1) {
>
> What is this change (> 0 → > 1) about?
>
Oooh, that's a typo, nice catch! I'll throw in a hot-fix when reposting!
next prev parent reply other threads:[~2010-10-22 0:20 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-22 0:05 [PATCH 01/15] mingw: implement syslog Erik Faye-Lund
2010-10-22 0:05 ` [PATCH 02/15] compat: add inet_pton and inet_ntop prototypes Erik Faye-Lund
2010-10-22 0:05 ` [PATCH 03/15] inet_ntop: fix a couple of old-style decls Erik Faye-Lund
2010-10-22 0:05 ` [PATCH 04/15] mingw: use real pid Erik Faye-Lund
2010-10-22 0:05 ` [PATCH 05/15] mingw: support waitpid with pid > 0 and WNOHANG Erik Faye-Lund
2010-10-22 0:05 ` [PATCH 06/15] mingw: add kill emulation Erik Faye-Lund
2010-10-22 0:05 ` [PATCH 07/15] daemon: use run-command api for async serving Erik Faye-Lund
2010-10-22 0:10 ` Jonathan Nieder
2010-10-22 0:20 ` Erik Faye-Lund [this message]
2010-10-22 0:05 ` [PATCH 08/15] daemon: use full buffered mode for stderr Erik Faye-Lund
2010-10-22 0:05 ` [PATCH 09/15] Improve the mingw getaddrinfo stub to handle more use cases Erik Faye-Lund
2010-10-22 0:05 ` [PATCH 10/15] daemon: get remote host address from root-process Erik Faye-Lund
2010-10-22 0:05 ` [PATCH 11/15] mingw: import poll-emulation from gnulib Erik Faye-Lund
2010-10-22 0:05 ` [PATCH 12/15] mingw: use " Erik Faye-Lund
2010-10-22 0:05 ` [PATCH 13/15] daemon: use socklen_t Erik Faye-Lund
2010-10-22 0:05 ` [PATCH 14/15] daemon: make --inetd and --detcach incompatible Erik Faye-Lund
2010-10-22 0:05 ` [PATCH 15/15] daemon: opt-out on features that require posix Erik Faye-Lund
2010-10-22 0:13 ` [PATCH 01/15] mingw: implement syslog Erik Faye-Lund
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='AANLkTikL-uWKUtcB=NS+42ajAGrLH1B9CEE6B-0Ykeiq@mail.gmail.com' \
--to=kusmabite@gmail.com \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=j6t@kdbg.org \
--cc=jrnieder@gmail.com \
--cc=msysgit@googlegroups.com \
--cc=patthoyts@gmail.com \
--cc=schwab@linux-m68k.org \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).