From: Thiago Farina <tfransosi@gmail.com>
To: Jonathan Nieder <jrnieder@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] commit: Add commit_list prefix to reduce_heads function.
Date: Sun, 5 Dec 2010 15:29:51 -0200 [thread overview]
Message-ID: <AANLkTikL4BWtzNgx1+MBYxRRdfL=Gu71KPjaiKXprvnb@mail.gmail.com> (raw)
In-Reply-To: <20101205170919.GA7913@burratino>
On Sun, Dec 5, 2010 at 3:09 PM, Jonathan Nieder <jrnieder@gmail.com> wrote:
> - "At my office there is a style guide indicating that each function
> should live in a module with some other functions and be named to
> indicate so (like perf, with its sched__* etc functions). The idea
> is that code with a simple high-level structure tends to be easier
> to understand and we need to understand the code we use. Can we
> start changing the code to fit this style guide, so there is less
> resistance to using it at my office?"
>
For me that is a good reason and I think it matches with what I had in
mind but didn't write. Thanks for pointing it out.
next prev parent reply other threads:[~2010-12-05 17:30 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-05 1:59 [PATCH] commit: Add commit_list prefix to reduce_heads function Thiago Farina
2010-12-05 2:18 ` Jonathan Nieder
2010-12-05 12:18 ` Thiago Farina
2010-12-05 17:09 ` Jonathan Nieder
2010-12-05 17:29 ` Thiago Farina [this message]
2010-12-05 17:32 ` Thiago Farina
2010-12-05 21:07 ` Junio C Hamano
2010-12-05 21:29 ` Thiago Farina
2010-12-06 3:58 ` Junio C Hamano
2010-12-06 4:01 ` Junio C Hamano
2010-12-05 5:24 ` Junio C Hamano
2010-12-05 12:23 ` Thiago Farina
2010-12-05 20:40 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='AANLkTikL4BWtzNgx1+MBYxRRdfL=Gu71KPjaiKXprvnb@mail.gmail.com' \
--to=tfransosi@gmail.com \
--cc=git@vger.kernel.org \
--cc=jrnieder@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).