From: Erik Faye-Lund <kusmabite@gmail.com>
To: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH/RFC 0/2] use libcharset.h with gettext if available
Date: Wed, 29 Sep 2010 13:41:37 +0200 [thread overview]
Message-ID: <AANLkTikMWy2a0M6bFMj+Jb+2QewUGsUjMsbv=XyR1Tr9@mail.gmail.com> (raw)
In-Reply-To: <AANLkTin90pKaVGVaG-4PW50TAhgfp1QVtrKpvyVxpnW0@mail.gmail.com>
On Wed, Sep 29, 2010 at 12:00 PM, Ævar Arnfjörð Bjarmason
<avarab@gmail.com> wrote:
> On Tue, Sep 28, 2010 at 21:47, Erik Faye-Lund <kusmabite@gmail.com> wrote:
>> On Tue, Sep 28, 2010 at 8:29 PM, Ævar Arnfjörð Bjarmason
>>> * Added defaults for NO_LIBCHARSET to the default, I only changed the
>>> defaults for the MINGW entry, maybe it should be changed on Cygwin
>>> and Windows too? And probably on OpenBSD and NetBSD too.
>>>
>>
>> I don't think NO_LIBCHARSET should be the default. libcharset is
>> reported to be a bit better than nl_langinfo at normalizing the
>> encoding, and GNU gettext depends on libcharset (through libiconv,
>> which libcharset is distributed with). So in the case of a GNU
>> gettext, libcharset should really be present.
>
> I can't find any package (with apt-file) on Debian or Ubuntu that
> provides libcharset.h, but I have langinfo.h on those systems.
>
Strange. A 'make install' on libiconv installed libcharset.h to
$prefix/include on my system. But looking a bit deeper, it seems that
glibc supplies it's own iconv implementation (perhaps based on
libiconv, I don't know). So yes, I tend to agree with you. GNU
platforms should not be expected to have libcharset.
> The GNU gettext manual also reccomends the use of nl_langinfo in
> "11.2.4 How to specify the output character set `gettext' uses", so it
> seems that using that and not libiconv is the default way of doing
> things on GNU gettext + GNU libc systems.
>
OK, fair enough. I based my comment on some comment by the GNU gettext
maintainer (who is also the libcharset maintainer - libcharset does in
fact use nl_langinfo if present), but since this is in the manual I
fully withdraw my comment.
Then again, if this is an opt-in rather than an opt-out, perhaps we
should change the switch to HAVE_LIBCHARSET? I don't mean to go in
circles here, but it sounds more self-documenting to me.
next prev parent reply other threads:[~2010-09-29 11:42 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-28 16:05 [PATCH] gettext: use libcharset when available Erik Faye-Lund
2010-09-28 17:07 ` Ævar Arnfjörð Bjarmason
2010-09-28 17:42 ` Erik Faye-Lund
2010-09-28 18:29 ` [PATCH/RFC 0/2] use libcharset.h with gettext if available Ævar Arnfjörð Bjarmason
2010-09-28 21:47 ` Erik Faye-Lund
2010-09-29 10:00 ` Ævar Arnfjörð Bjarmason
2010-09-29 11:41 ` Erik Faye-Lund [this message]
2010-09-29 13:07 ` [PATCH] gettext: use libcharset when available Ævar Arnfjörð Bjarmason
2010-09-29 13:34 ` Erik Faye-Lund
2010-09-29 13:40 ` [PATCH v2] " Ævar Arnfjörð Bjarmason
2010-09-29 13:43 ` [PATCH v3] " Ævar Arnfjörð Bjarmason
2010-09-28 18:29 ` [PATCH/RFC 1/2] gettext: use const char* instead of char* Ævar Arnfjörð Bjarmason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='AANLkTikMWy2a0M6bFMj+Jb+2QewUGsUjMsbv=XyR1Tr9@mail.gmail.com' \
--to=kusmabite@gmail.com \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).