git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Áshin László" <ashinlaszlo@gmail.com>
To: git@vger.kernel.org
Subject: [PATCH 3/4] git-cvsserver: do not try to descramble empty password
Date: Sat, 3 Jul 2010 23:23:29 +0200	[thread overview]
Message-ID: <AANLkTikUyBMOASPSQeyMLa_Vhp0QdP__c0kIsCMarY8L@mail.gmail.com> (raw)
In-Reply-To: <-1644121413921817001@unknownmsgid>

 git-cvsserver.perl |    6 +++++-
 1 files changed, 5 insertions(+), 1 deletions(-)

diff --git a/git-cvsserver.perl b/git-cvsserver.perl
index 46e5fdb..01c5b21 100755
--- a/git-cvsserver.perl
+++ b/git-cvsserver.perl
@@ -235,11 +235,15 @@ if ($state->{method} eq 'pserver') {
            exit 1;
        }

+        if (length($password) > 0) {
+            $password = descramble($password);
+        }
+
        my $auth_ok;
        open my $passwd, "<", $authdb or die $!;
        while (<$passwd>) {
            if (m{^\Q$user\E:(.*)}) {
-                if (crypt($user, descramble($password)) eq $1) {
+                if (crypt($user, $password) eq $1) {
                    $auth_ok = 1;
                }
            };
--
1.7.2.rc1.dirty

           reply	other threads:[~2010-07-03 21:23 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <-1644121413921817001@unknownmsgid>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=AANLkTikUyBMOASPSQeyMLa_Vhp0QdP__c0kIsCMarY8L@mail.gmail.com \
    --to=ashinlaszlo@gmail.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).