From: Davi Reis <davi.reis@gmail.com>
To: Matthieu Moy <Matthieu.Moy@grenoble-inp.fr>
Cc: git@vger.kernel.org
Subject: Re: Do not let lstree output recursively when a directory whose name is a prefix of the others is given in the path list.
Date: Thu, 9 Sep 2010 11:26:09 -0700 [thread overview]
Message-ID: <AANLkTikZ11-3QhOxoW096cdA4LryuZQiegg=GLMO0BJB@mail.gmail.com> (raw)
In-Reply-To: <vpqzkvr5u73.fsf@bauges.imag.fr>
I added the test and used git-sendemail again, but I guess it ended up
in a different thread. Is this good enough or is there some formal
path that I should take? Any help appreciated.
On Wed, Sep 8, 2010 at 11:04 PM, Matthieu Moy
<Matthieu.Moy@grenoble-inp.fr> wrote:
> davi.reis@gmail.com writes:
>
>> Here is how to reproduce the bug:
>>
>> git init
>> mkdir prefix && touch prefix/a && git add prefix/a
>> mkdir prefixdir && touch prefixdir/b && git add prefixdir/b
>> git commit -a -m "If -r is not given, ls-tree should not show files in subdirs."
>> git ls-tree --name-only HEAD prefix # works as expected
>> git ls-tree --name-only HEAD prefixdir # works as expected
>> git ls-tree --name-only HEAD prefix prefixdir # shows file, not dir
>
> That's so close to a real test-case... You should incorporate this in
> your patch (e.g. in t/t3101-ls-tree-dirname.sh), to make sure such bug
> never happens again.
>
> --
> Matthieu Moy
> http://www-verimag.imag.fr/~moy/
>
--
[]s
Davi de Castro Reis
next prev parent reply other threads:[~2010-09-09 18:26 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-09 5:40 Do not let lstree output recursively when a directory whose name is a prefix of the others is given in the path list davi.reis
2010-09-09 5:40 ` [PATCH] " davi.reis
2010-09-09 6:04 ` Matthieu Moy
2010-09-09 18:26 ` Davi Reis [this message]
2010-09-09 21:22 ` Matthieu Moy
2010-09-11 18:57 ` Junio C Hamano
2010-09-11 19:00 ` [PATCH 2/2] ls-tree $di $dir: do not mistakenly recurse into directories Junio C Hamano
2010-09-14 21:22 ` Do not let lstree output recursively when a directory whose name is a prefix of the others is given in the path list Matthieu Moy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='AANLkTikZ11-3QhOxoW096cdA4LryuZQiegg=GLMO0BJB@mail.gmail.com' \
--to=davi.reis@gmail.com \
--cc=Matthieu.Moy@grenoble-inp.fr \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).