From: Diane Gasselin <diane.gasselin@ensimag.imag.fr>
To: Junio C Hamano <gitster@pobox.com>
Cc: "Axel Bonnet" <axel.bonnet@ensimag.imag.fr>,
git@vger.kernel.org,
"Clément Poulain" <clement.poulain@ensimag.imag.fr>
Subject: Re: [PATCH v2 3/3] t/t8006: test textconv support for blame
Date: Mon, 14 Jun 2010 09:52:48 +0200 [thread overview]
Message-ID: <AANLkTikZCtymKUgD3uYj7kU3HDuo2Y-oJr2f10CKRbgU@mail.gmail.com> (raw)
In-Reply-To: <7vd3vxgm9x.fsf@alter.siamese.dyndns.org>
Le 12 juin 2010 01:52, Junio C Hamano <gitster@pobox.com> a écrit :
> Axel Bonnet <axel.bonnet@ensimag.imag.fr> writes:
>
>> Test the correct functionning of textconv with blame <file> and blame HEAD^ <file>.
>> Test the case when no driver is specified.
>
> Good to see tests for both positive and negative cases. Too many people
> forget the latter.
>
>> +find_blame() {
>> + sed -e 's/^.*(/(/g'
>> +}
>
> Two issues:
>
> - No need for "g" as your pattern is anchored at the left;
>
> - As ".*" is greedy, you will eat a lot more than what you expect when
> the line in the blamed contents happen to have '(' on it.
>
> I'd rewrite it as:
>
> sed -e 's/^[^(]*//'
>
> Will queue all three patches, with this fix and a style fix for 2/3; no
> need to resend.
>
> Thanks.
>
Thanks. And thanks for fixing.
next prev parent reply other threads:[~2010-06-14 7:53 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-07 14:41 [PATCH v2 0/3] textconv support for blame Axel Bonnet
2010-06-07 15:23 ` [PATCH v2 1/3] textconv: make the API public Axel Bonnet
2010-06-07 15:23 ` [PATCH v2 2/3] textconv: support for blame Axel Bonnet
2010-06-07 15:23 ` [PATCH v2 3/3] t/t8006: test textconv " Axel Bonnet
2010-06-11 23:52 ` Junio C Hamano
2010-06-14 7:52 ` Diane Gasselin [this message]
2010-06-11 23:52 ` [PATCH v2 2/3] textconv: " Junio C Hamano
2010-06-12 4:11 ` Jeff King
2010-06-14 20:40 ` Junio C Hamano
2010-06-15 9:29 ` Clément Poulain
2010-06-15 9:54 ` Jeff King
2010-06-15 10:32 ` bonneta
2010-06-15 10:51 ` Matthieu Moy
[not found] ` <aad13a73928536f87879ef7284d6cc75@ensimag.fr>
2010-06-15 11:07 ` Jeff King
2010-06-15 12:13 ` bonneta
2010-06-15 15:00 ` Junio C Hamano
2010-06-15 13:58 ` Axel Bonnet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AANLkTikZCtymKUgD3uYj7kU3HDuo2Y-oJr2f10CKRbgU@mail.gmail.com \
--to=diane.gasselin@ensimag.imag.fr \
--cc=axel.bonnet@ensimag.imag.fr \
--cc=clement.poulain@ensimag.imag.fr \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).