From: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
To: "Dmitry V. Levin" <ldv@altlinux.org>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] checkout: add a test for creating a new branch with regexp as a starting point
Date: Fri, 30 Jul 2010 11:54:00 +0000 [thread overview]
Message-ID: <AANLkTikan0hnUa-p-U1dfRKq+bORmrn7A3YTPOPe2N_k@mail.gmail.com> (raw)
In-Reply-To: <20100730084428.GA9577@wo.int.altlinux.org>
On Fri, Jul 30, 2010 at 08:44, Dmitry V. Levin <ldv@altlinux.org> wrote:
> On Thu, Jul 29, 2010 at 11:07:20PM +0000, Ævar Arnfjörð Bjarmason wrote:
>> On Thu, Jul 29, 2010 at 22:01, Dmitry V. Levin wrote:
> [...]
>> > +test_expect_success setup '
>> > + echo a > a &&
>> > + git add a &&
>> > + test_tick &&
>> > + git commit -m first &&
>> > + echo b > b &&
>> > + git add b &&
>> > + test_tick &&
>> > + git commit -m second
>> > +'
>>
>> This should use test_commit (see t/README), but...
>
> The peculiarity of this bug makes it impossible, because test_commit()
> also creates a tag which spoils test conditions.
I didn't know that. It'd be good if the commit message or a comment
indicated that. And actually, we should probably have a
test_commit_notag() then.
>> > +test_expect_success checkout '
>> > + git checkout -b new_branch :/first
>> > +'
>> > +
>> > +test_done
>>
>> ...it looks like this can just be added to the end of
>> t2018-checkout-branch.sh instead of creating a new test. Creating a
>> new file just for a single test for such a simple feature is a bit of
>> an overkill.
>
> Well, I see no t2018-checkout-branch.sh yet. What file do you suggest
> appending?
Ah, t2018-checkout-branch.sh only exists on the pu branch, not
master/next. It's probably worthwhile to patch it anyway rather than
adding a new one.
next prev parent reply other threads:[~2010-07-30 11:54 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-29 22:01 [PATCH] checkout: add a test for creating a new branch with regexp as a starting point Dmitry V. Levin
2010-07-29 23:07 ` Ævar Arnfjörð Bjarmason
2010-07-29 23:36 ` Thomas Rast
2010-07-30 8:44 ` Dmitry V. Levin
2010-07-30 11:54 ` Ævar Arnfjörð Bjarmason [this message]
2010-07-30 19:13 ` When to use test_commit (Re: [PATCH] checkout: add a test for creating a new branch with regexp as a starting point) Jonathan Nieder
2010-07-30 20:20 ` Ævar Arnfjörð Bjarmason
2010-07-31 0:18 ` [PATCH 1/2] test-lib.sh: introduce 4th argument to test_commit() specifying a tag name Dmitry V. Levin
2010-07-31 0:39 ` Ævar Arnfjörð Bjarmason
2010-07-31 1:56 ` [PATCH 1/2 v2] " Dmitry V. Levin
2010-07-31 10:23 ` Ævar Arnfjörð Bjarmason
2010-07-31 0:19 ` [PATCH 2/2] checkout: add a test for creating a new branch with regexp as a starting point Dmitry V. Levin
2010-07-31 0:44 ` Ævar Arnfjörð Bjarmason
2010-07-31 1:44 ` [PATCH 2/2 v2] " Dmitry V. Levin
2010-07-31 10:24 ` Ævar Arnfjörð Bjarmason
2010-08-05 21:24 ` [PATCH 2/2 v3] " Dmitry V. Levin
2010-08-02 21:04 ` [PATCH] " Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AANLkTikan0hnUa-p-U1dfRKq+bORmrn7A3YTPOPe2N_k@mail.gmail.com \
--to=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=ldv@altlinux.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).