From: Martin von Zweigbergk <martin.von.zweigbergk@gmail.com>
To: git@vger.kernel.org
Cc: Johannes.Schindelin@gmx.de, christian.couder@gmail.com,
trast@student.ethz.ch, Christian Couder <chriscool@tuxfamily.org>
Subject: Re: Refactoring git-rebase.sh and git-rebase--interactive.sh
Date: Sat, 6 Nov 2010 21:57:25 -0400 [thread overview]
Message-ID: <AANLkTikbSU7LMnrT7uz5SSd8_x_cK_dHiVN37McJe+AT@mail.gmail.com> (raw)
In-Reply-To: <AANLkTinSb09oZHN8br5goeoG2b+Cgra88E1qeLqi-Y=z@mail.gmail.com>
> 2. a. If --continue, --skip or --abort requested, rebase-apply/ or
> rebase-merge/ must exist. (What if -i is also passed and
> rebase-apply/ exists?)
> b. Otherwise, rebase-apply/ or rebase-merge/ must not exist
This actually hints at a more general question, namely whether command
line or saved options should be used when continuing a rebase. For
example, if an interactive rebase has been started with a certain merge
strategy, should that merge strategy be used throughout the rebase, or
should whatever is passed on the command line when continuing be used
instead? Does it depend on which option we are talking about?
As far as I can understand from the code, it seems like non-interactive
rebase currently does not store e.g. the merge strategy, but allows it
to be passed on the command line together with '--continue' (but only if
passed before). Interactive rebase, OTOH, does store the option when the
rebase is initated and does not allow it to be overriden on the command
line. I have not tested either of them, so I may very well be wrong.
Whatever the current behavior is, how do you think it *should* behave?
prev parent reply other threads:[~2010-11-07 2:03 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-02 12:33 Refactoring git-rebase.sh and git-rebase--interactive.sh Martin von Zweigbergk
2010-11-02 12:46 ` Johannes Sixt
2010-11-03 3:24 ` Christian Couder
2010-11-03 12:22 ` Martin von Zweigbergk
2010-11-04 21:15 ` Yann Dirson
2010-11-04 21:49 ` Pat Notz
2010-11-05 8:58 ` Christian Couder
2010-11-06 2:03 ` Martin von Zweigbergk
2010-11-07 1:57 ` Martin von Zweigbergk [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AANLkTikbSU7LMnrT7uz5SSd8_x_cK_dHiVN37McJe+AT@mail.gmail.com \
--to=martin.von.zweigbergk@gmail.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=chriscool@tuxfamily.org \
--cc=christian.couder@gmail.com \
--cc=git@vger.kernel.org \
--cc=trast@student.ethz.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).