[FEATURE REQUEST] - extend git request-pull to send email

[FEATURE REQUEST] - extend git request-pull to send email

[Eugene Sajine]

Hi,

The command "git request-pull" doesn't actually request anything but
just outputs a nice report about pending changes.
I would suggest to extend "git request-pull" to be able to send email
with the information generated by the command using "git send-mail"
functionality. By default it could take some values from the
environment, like the sender information, the subject and of course
the body of the message.

Specifying the "--to user@server.com" could be a trigger for this functionality.
All additional parameters from git send-mail should be available.

What do you think?


Thanks,
Eugene

Re: [FEATURE REQUEST] - extend git request-pull to send email

[Junio C Hamano]

Eugene Sajine <euguess@gmail.com> writes:

> Specifying the "--to user@server.com" could be a trigger for this functionality.
> All additional parameters from git send-mail should be available.
>
> What do you think?

Horrible ;-).

If this were not about request-pull but some other command that produces a
summary of recent changes you have, which you might want to distribute to
people who are involved in the project (e.g. Meta/cook), it might make
sense to have "generate and then e-mail" feature inside the command,
because such a command needs to inspect the history and grab various kinds
of information anyway, and adding "people involved" to the mix might make
sense.

But you are talking about request-pull, which is by design is meant to be
sent to a single recipient.  If the user has to say --to user@example.com,
how is it different from piping the output to "| mail to@example.com"?

Re: [FEATURE REQUEST] - extend git request-pull to send email

[Junio C Hamano]

Junio C Hamano <gitster@pobox.com> writes:

>> What do you think?
>
> Horrible ;-).

Just a quick note.

Please take this with a huge grain of salt, considering that the comment
is coming from somebody who thinks --compose and format-patch integration
to git-send-email was also a bad idea.

Re: [FEATURE REQUEST] - extend git request-pull to send email

[Eugene Sajine]

On Thu, Feb 3, 2011 at 6:06 PM, Junio C Hamano <gitster@pobox.com> wrote:
> Junio C Hamano <gitster@pobox.com> writes:
>
>>> What do you think?
>>
>> Horrible ;-).
>
> Just a quick note.
>
> Please take this with a huge grain of salt, considering that the comment
> is coming from somebody who thinks --compose and format-patch integration
> to git-send-email was also a bad idea.
>

;) Anyway thanks for prompt answer;))

Well, it is of course pretty cool that you can pipe the output to mail
but there are at least three problems that i currently see with this:

1. it is not cross-platform solution
2. By default subject gets empty;)
3. I probably would like the from address to be the one that I'm using
in git configuration...

Thanks,
Eugene

Re: [FEATURE REQUEST] - extend git request-pull to send email

[Eugene Sajine]

> 3. I probably would like the from address to be the one that I'm using
> in git configuration...

It probably should be the reply-to....


 Thanks,
 Eugene