git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
To: git@vger.kernel.org
Cc: "Jan Krüger" <jk@jk.gs>, "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Subject: Re: [PATCH/RFC 3/8] gettextize: git-pull eval_gettext + die message
Date: Mon, 13 Sep 2010 21:57:45 +0000	[thread overview]
Message-ID: <AANLkTikn8wB+DhoDJfKOiiNOVSAh0wd49ogpP_WDQ_DA@mail.gmail.com> (raw)
In-Reply-To: <1284406558-23684-4-git-send-email-avarab@gmail.com>

On Mon, Sep 13, 2010 at 19:35, Ævar Arnfjörð Bjarmason <avarab@gmail.com> wrote:

> -$ git diff '$orig_head'
> +\$ git diff \$orig_head
>  output, run
> -$ git reset --hard
> -to recover.'
> +\$ git reset --hard
> +to recover.")"

"make pot" rightly whines about this:

    git-pull.sh:265: warning: Although being used in a format string
    position, the msgid is not a valid Shell format string. Reason:
    The string refers to a shell variable whose value may be different
    inside shell functions.

Just using "$" instead of "\$" for "$ git ...." works,
i.e. eval_gettext "foo $ bar" instead of eval_gettext "foo \$ bar".

Is that portable? Is " $ " always the same as ' $ ' in POSIX shells?

  reply	other threads:[~2010-09-13 21:57 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-09-13 19:35 [PATCH/RFC 0/8] gettextize: git-pull Ævar Arnfjörð Bjarmason
2010-09-13 19:35 ` [PATCH/RFC 1/8] gettextize: git-pull add git-sh-i18n Ævar Arnfjörð Bjarmason
2010-09-13 19:35 ` [PATCH/RFC 2/8] gettextize: git-pull die messages Ævar Arnfjörð Bjarmason
2010-09-13 19:35 ` [PATCH/RFC 3/8] gettextize: git-pull eval_gettext + die message Ævar Arnfjörð Bjarmason
2010-09-13 21:57   ` Ævar Arnfjörð Bjarmason [this message]
2010-09-13 19:35 ` [PATCH/RFC 4/8] gettextize: git-pull eval_gettext + warning message Ævar Arnfjörð Bjarmason
2010-09-13 19:35 ` [PATCH/RFC 5/8] gettextize: git-pull split up "no candidate" message Ævar Arnfjörð Bjarmason
2010-09-13 19:35 ` [PATCH/RFC 6/8] gettextize: git-pull "You asked to pull" message Ævar Arnfjörð Bjarmason
2010-09-13 19:35 ` [PATCH/RFC 7/8] gettextize: git-pull "[...] not currently on a branch" message Ævar Arnfjörð Bjarmason
2010-09-13 19:35 ` [PATCH/RFC 8/8] gettextize: git-pull "rebase against" / "merge with" messages Ævar Arnfjörð Bjarmason

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=AANLkTikn8wB+DhoDJfKOiiNOVSAh0wd49ogpP_WDQ_DA@mail.gmail.com \
    --to=avarab@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=jk@jk.gs \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).