Re: [PATCH 1/3] git-instaweb: Fix custom apache log placement

[Dan McGee <dpmcgee@gmail.com>]

On Tue, Jun 29, 2010 at 9:44 PM, Dan McGee <dpmcgee@gmail.com> wrote:
> 'CustomLog' is provided by mod_log_config so we need to include the module
> in our generated config. This was added in d94775e1f9a.
>
> Signed-off-by: Dan McGee <dpmcgee@gmail.com>

I noticed this set of patches didn't go anywhere...at least the first
two were more bug fixes than improvements so I would have expected
them to get into 1.7.2. Did they get lost in the shuffle?

1: http://marc.info/?l=git&m=127786592330110&w=2
2: http://marc.info/?l=git&m=127786592030105&w=2
3: http://marc.info/?l=git&m=127791591706076&w=2

-Dan

> ---
>  git-instaweb.sh |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/git-instaweb.sh b/git-instaweb.sh
> index 6635fbe..a01476a 100755
> --- a/git-instaweb.sh
> +++ b/git-instaweb.sh
> @@ -314,7 +314,7 @@ PidFile "$fqgitdir/pid"
>  Listen $bind$port
>  EOF
>
> -       for mod in mime dir; do
> +       for mod in mime dir log_config; do
>                if test -e $module_path/mod_${mod}.so; then
>                        echo "LoadModule ${mod}_module " \
>                             "$module_path/mod_${mod}.so" >> "$conf"
> --
> 1.7.1
>
>