From: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: Brian Gernhardt <brian@gernhardtsoftware.com>,
Git Mailing List <git@vger.kernel.org>
Subject: Re: [PATCH] t7003: Use test_commit instead of custom function
Date: Mon, 13 Sep 2010 15:46:13 +0000 [thread overview]
Message-ID: <AANLkTikqGLvMHzsa4We7OUcYz5o2v62huO1OhiYLPHeS@mail.gmail.com> (raw)
In-Reply-To: <alpine.DEB.1.00.1009131741270.2439@intel-tinevez-2-302>
On Mon, Sep 13, 2010 at 15:44, Johannes Schindelin
<Johannes.Schindelin@gmx.de> wrote:
> Hi,
>
> On Mon, 13 Sep 2010, Ævar Arnfjörð Bjarmason wrote:
>
>> On Mon, Sep 13, 2010 at 15:24, Brian Gernhardt
>> <brian@gernhardtsoftware.com> wrote:
>> > On Sep 13, 2010, at 8:11 AM, Ævar Arnfjörð Bjarmason <avarab@gmail.com> wrote:
>>
>> > In addition, why do we need a custom make_commit when we have
>> > test_commit in test-lib.sh?
>>
>> It was added in v1.5.3-rc0~69^2~10 by Johannes Schindelin (CC'd). It's
>> probably just now-needless duplication, but I haven't familirized myself
>> with the code.
>
> Yep, I did not make a cleanup patch after adding test_commit. Neither did
> I consolidate other cases in t/ where the steps are done explicitly.
Thanks. I didn't check when test_commit was added, it makes sense now.
There's a lot of old spiderwebs like that in t/* that could now use
cleanup.
prev parent reply other threads:[~2010-09-13 15:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-10 22:06 [PATCH] t7003: Use test_commit instead of custom function Brian Gernhardt
2010-09-13 4:14 ` Brian Gernhardt
2010-09-13 12:11 ` Ævar Arnfjörð Bjarmason
[not found] ` <2CFDEC64-9F88-4510-A4FE-DB708CA62224@gernhardtsoftware.com>
[not found] ` <AANLkTi=v+EXucegQ20oskr_cr5WJoTO+zCXPEB-J+Ucs@mail.gmail.com>
[not found] ` <alpine.DEB.1.00.1009131741270.2439@intel-tinevez-2-302>
2010-09-13 15:46 ` Ævar Arnfjörð Bjarmason [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AANLkTikqGLvMHzsa4We7OUcYz5o2v62huO1OhiYLPHeS@mail.gmail.com \
--to=avarab@gmail.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=brian@gernhardtsoftware.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).