From: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
To: Johannes Sixt <j6t@kdbg.org>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] Do not build i18n on Windows.
Date: Fri, 13 Aug 2010 22:19:34 +0000 [thread overview]
Message-ID: <AANLkTiku5R+idX-C8f0AcCikBLmfEb5ZEhdft+CSRzU0@mail.gmail.com> (raw)
In-Reply-To: <201008140002.40587.j6t@kdbg.org>
On Fri, Aug 13, 2010 at 22:02, Johannes Sixt <j6t@kdbg.org> wrote:
> We do not have the necessary libraries and tools.
Just curious, do you mean Windows / MINGW can't build gettext, or that
you just haven't done so in your build process yet? At least
http://www.mingw.org/wiki/LibrariesAndTools seems to indicate that
libintl has been ported to Windows.
If you're just not interested in building gettext by default on
Windows I think it's completely reasonable to add it to the Makefile
(given that you're probably pretty much the only one doing so). It
would just be useful to clarify the "why".
> Signed-off-by: Johannes Sixt <j6t@kdbg.org>
> ---
> It is necessary to move the first check for NO_GETTEXT after the
> configuration section.
>
> NEEDS_LIBINTL receives a default setting before the configuration
> section (not visible in the patch text), hence, I have to unset it
> when NO_GETTEXT is set. Perhaps you have a better idea to arrange
> these settings.
This seems backwards. Instead of removing the check from the LIB_OBJS
assignment and adding it in later I think we could just move the giant
"Platform specific tweaks" section so that it appears before all those
assignments, and directly after "export PYTHON_PATH".
I tried doing so locally and Git builds and tests fine, but I've only
done so on one platform, so I might have missed something.
next prev parent reply other threads:[~2010-08-13 22:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-13 22:02 [PATCH] Do not build i18n on Windows Johannes Sixt
2010-08-13 22:19 ` Ævar Arnfjörð Bjarmason [this message]
2010-08-14 8:24 ` Johannes Sixt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AANLkTiku5R+idX-C8f0AcCikBLmfEb5ZEhdft+CSRzU0@mail.gmail.com \
--to=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=j6t@kdbg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).