git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Nguyen Thai Ngoc Duy <pclouds@gmail.com>
To: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Cc: Git Mailing List <git@vger.kernel.org>
Subject: Re: Breaking t1510-repo-setup.sh tests in pu
Date: Thu, 25 Nov 2010 18:40:33 +0700	[thread overview]
Message-ID: <AANLkTikvXhKoRg4a0FuyW8cG45b6AM9+NbbHuJQWtb4L@mail.gmail.com> (raw)
In-Reply-To: <AANLkTim=_0WiphBv-RBhJ2i9rGzXvz8yKcZcm_7pYXFc@mail.gmail.com>

2010/11/25 Ævar Arnfjörð Bjarmason <avarab@gmail.com>:
> All the breakages seem to be due to path differences:
>
>    --- expected    2010-11-25 09:53:46.000000000 +0000
>    +++ result      2010-11-25 09:53:46.000000000 +0000
>    @@ -1,4 +1,4 @@
>    -setup: git_dir: /home/avar/g/git/t/trash directory.t1510-repo-setup/3/.git
>    -setup: worktree: /home/avar/g/git/t/trash directory.t1510-repo-setup/3/wt
>    +setup: git_dir: .git
>    +setup: worktree: /home/avar/g/git/t/trash directory.t1510-repo-setup/3
>     setup: cwd: /home/avar/g/git/t/trash directory.t1510-repo-setup/3
>     setup: prefix: (null)
>    not ok - 24 #3: GIT_DIR, GIT_WORK_TREE=wt at root
>
> This is probably due to Nguyễn's recent work. But I'm not sure.
>

Interesting. That looks like real breakage. I have just run the tests
on pu (f4b0626). It passed. Can you send me the entire log and
/tmp/t1510-trace.log after applying this patch?

diff --git a/t/t1510-repo-setup.sh b/t/t1510-repo-setup.sh
index 0343045..446eb4d 100755
--- a/t/t1510-repo-setup.sh
+++ b/t/t1510-repo-setup.sh
@@ -4,6 +4,8 @@ test_description='Tests of cwd/prefix/worktree/gitdir
setup in all cases'

 . ./test-lib.sh

+export GIT_TRACE=/tmp/t1510-trace.log
+
 #
 # A few rules for repo setup:
 #
-- 
Duy

  reply	other threads:[~2010-11-25 11:41 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-25  9:56 Breaking t1510-repo-setup.sh tests in pu Ævar Arnfjörð Bjarmason
2010-11-25 11:40 ` Nguyen Thai Ngoc Duy [this message]
     [not found]   ` <AANLkTinhgMhrcMtPKL0aOrkeVgo8NE8Sq0fuPuCcbdbq@mail.gmail.com>
2010-11-26  2:45     ` Nguyen Thai Ngoc Duy
2010-11-26  7:51       ` Johannes Sixt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=AANLkTikvXhKoRg4a0FuyW8cG45b6AM9+NbbHuJQWtb4L@mail.gmail.com \
    --to=pclouds@gmail.com \
    --cc=avarab@gmail.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).