git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
To: "Nathan W. Panike" <nathan.panike@gmail.com>
Cc: git@vger.kernel.org, Peter Kjellerstedt <peter.kjellerstedt@axis.com>
Subject: Re: [PATCH RFC] Add a config verbose option fetch and push
Date: Fri, 21 May 2010 17:10:22 +0000	[thread overview]
Message-ID: <AANLkTil-PDpdkcJaJn2FUrJrSIJ6lP0OcvY5l7HRorsa@mail.gmail.com> (raw)
In-Reply-To: <4bf6b6f5.dd79dc0a.5533.2acd@mx.google.com>

Since Peter Kjellerstedt wanted --ff-only, and you want --verbose. I
wonder whether a better solution wouldn't be to farm this
functionality out to the config parser.

I.e. you'd do something like:

    static struct option builtin_fetch_options[] = {
        OPT__PROGRAM_NAME("fetch"), /* this is new */
	    OPT__VERBOSITY(&verbosity),
    	OPT_BOOLEAN(0, "all", &all,
	    	    "fetch from all remotes"),
        ...

And then in your .gitconfig:

    [fetch "option"]
        verbose = 1

Is there any reason not to add such a general facility?

  reply	other threads:[~2010-05-21 17:10 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-05-21 13:26 [PATCH RFC] Add a config verbose option fetch and push Nathan W. Panike
2010-05-21 17:10 ` Ævar Arnfjörð Bjarmason [this message]
2010-05-22 10:44   ` Thomas Rast
2010-05-22 12:01     ` Ævar Arnfjörð Bjarmason
2010-05-22 13:34       ` Thomas Rast
2010-05-22 14:15         ` Ævar Arnfjörð Bjarmason
  -- strict thread matches above, loose matches on Subject: below --
2010-05-21 13:26 Nathan W. Panike
2010-05-21 14:53 ` Peter Kjellerstedt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=AANLkTil-PDpdkcJaJn2FUrJrSIJ6lP0OcvY5l7HRorsa@mail.gmail.com \
    --to=avarab@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=nathan.panike@gmail.com \
    --cc=peter.kjellerstedt@axis.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).