From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sverre Rabbelier Subject: Re: [PATCH] Fix a false negative in t5512 when run using sh -x Date: Mon, 10 May 2010 12:45:14 +0200 Message-ID: References: <1273475946-2079-1-git-send-email-j6t@kdbg.org> <4BE7DEB8.5000900@viscovery.net> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Cc: Junio C Hamano , git@vger.kernel.org, Tay Ray Chuan To: Johannes Sixt X-From: git-owner@vger.kernel.org Mon May 10 12:45:43 2010 connect(): No such file or directory Return-path: Envelope-to: gcvg-git-2@lo.gmane.org Received: from vger.kernel.org ([209.132.180.67]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1OBQUY-0008Eb-VJ for gcvg-git-2@lo.gmane.org; Mon, 10 May 2010 12:45:43 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756696Ab0EJKph (ORCPT ); Mon, 10 May 2010 06:45:37 -0400 Received: from mail-wy0-f174.google.com ([74.125.82.174]:63836 "EHLO mail-wy0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756691Ab0EJKpf (ORCPT ); Mon, 10 May 2010 06:45:35 -0400 Received: by wyf19 with SMTP id 19so740150wyf.19 for ; Mon, 10 May 2010 03:45:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:mime-version:received:in-reply-to :references:from:date:message-id:subject:to:cc:content-type; bh=rnTMNHpwYpUfG0Z2ljsevR1nLHZYQGI+jZOUVeyYQnI=; b=hFzhacVn4v0XEiah+DRbPk1B1iAeourtO1CZPs+EpIXhc6aGOCrYwM0AQZB7W3hb+e b/6YX3i1P55YyE3Dg7mroDMIXlXqYmx2dzzpYfDS29N6UNoI9AXNrzflPcTzlLmtxy2Q MDIFEBsr2UC4PZwm4Io3f3/c/nv0pt/7XjBwc= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; b=eXGEKCNZ0gjxeizH3UwGByChGXOGWc8epeqicRN97xxVn8Nb16k+rvbug78bxdrCJv VmqsHgJioIRZoamY83j6WJsyBoyTmXYiLh6dvMfbI/0GaWZhOo5j0BowSknvCR5x9BVp CUlsI2XWkhSs2cIwM9Uv/m9SSl/0ARJEQmSRo= Received: by 10.216.168.84 with SMTP id j62mr2283630wel.89.1273488334157; Mon, 10 May 2010 03:45:34 -0700 (PDT) Received: by 10.216.60.147 with HTTP; Mon, 10 May 2010 03:45:14 -0700 (PDT) In-Reply-To: <4BE7DEB8.5000900@viscovery.net> Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: Heya, On Mon, May 10, 2010 at 12:23, Johannes Sixt wrote: > This is really only special because the test_cmp looked at the stderr of a > test_must_fail command. The old code was: [...] > i.e., there were command traces in the file. Ah, that makes sense. Did you check if other tests are not affected by the same problem (by running all tests with -x)? -- Cheers, Sverre Rabbelier