From: Gisle Aas <gisle@aas.no>
To: Jeff King <peff@peff.net>
Cc: "Junio C Hamano" <gitster@pobox.com>,
"Ævar Arnfjörð" <avarab@gmail.com>,
git@vger.kernel.org
Subject: Re: Make author and committer available to pre-commit hook
Date: Tue, 6 Jul 2010 11:22:07 +0200 [thread overview]
Message-ID: <AANLkTilsdbJLHTY7cx2GeZg9ai_OZhmnEt0KdFjF81Pd@mail.gmail.com> (raw)
In-Reply-To: <20100706072947.GB3567@sigill.intra.peff.net>
On Tue, Jul 6, 2010 at 09:29, Jeff King <peff@peff.net> wrote:
> On Mon, Jul 05, 2010 at 08:04:39PM -0700, Junio C Hamano wrote:
>
>> I wonder if we should also make author/committer dates available via the
>> same mechanism.
>
> I don't see why not. It is a trivial amount of code, and I can see at
> least author date being useful.
One question that arise is what format the date variables should have.
Is the raw format (that is "1278400946 +0200") sensible?
I've created a patch for this locally, but it has some side effects in
messing up the dates stored by 'git commit -C...' which I have not
figured out yet; and now I need to get some other stuff done. It
might take some days until a revised patch is ready. Feel free to
contribute your "trivial amount of code" before I get around to it :-)
Regards,
Gisle
next prev parent reply other threads:[~2010-07-06 9:22 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-05 11:30 Make author and committer available to pre-commit hook Gisle Aas
2010-07-05 11:46 ` Jeff King
2010-07-05 18:04 ` Gisle Aas
2010-07-05 21:31 ` Ævar Arnfjörð Bjarmason
2010-07-06 3:04 ` Junio C Hamano
2010-07-06 7:29 ` Jeff King
2010-07-06 9:22 ` Gisle Aas [this message]
2010-07-06 15:47 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AANLkTilsdbJLHTY7cx2GeZg9ai_OZhmnEt0KdFjF81Pd@mail.gmail.com \
--to=gisle@aas.no \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).