* what is the test target of t9400-git-cvsserver-server.sh
@ 2010-07-03 17:04 Áshin László
2010-07-03 20:52 ` Ævar Arnfjörð Bjarmason
0 siblings, 1 reply; 3+ messages in thread
From: Áshin László @ 2010-07-03 17:04 UTC (permalink / raw)
To: git
Hi,
t9400-git-cvsserver-server.sh refers to git-cvsserver as CVS_SERVER
for the cvs client:
CVS_SERVER=git-cvsserver
What is the goal of this test? To test the git-cvsserver executable
found in the system (in $PATH), or the one bundled in the git source
distribution? I would think that unit tests are to be run before make
install, so it should test the latter. I have a patch already to fix
that and I will post it in case I am right.
Regards,
László ÁSHIN
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: what is the test target of t9400-git-cvsserver-server.sh
2010-07-03 17:04 what is the test target of t9400-git-cvsserver-server.sh Áshin László
@ 2010-07-03 20:52 ` Ævar Arnfjörð Bjarmason
2010-07-03 21:28 ` Áshin László
0 siblings, 1 reply; 3+ messages in thread
From: Ævar Arnfjörð Bjarmason @ 2010-07-03 20:52 UTC (permalink / raw)
To: Áshin László; +Cc: git
On Sat, Jul 3, 2010 at 17:04, Áshin László <ashinlaszlo@gmail.com> wrote:
> t9400-git-cvsserver-server.sh refers to git-cvsserver as CVS_SERVER
> for the cvs client:
> CVS_SERVER=git-cvsserver
>
> What is the goal of this test? To test the git-cvsserver executable
> found in the system (in $PATH), or the one bundled in the git source
> distribution? I would think that unit tests are to be run before make
> install, so it should test the latter. I have a patch already to fix
> that and I will post it in case I am right.
Have you noticed that test-lib.sh sets PATH to include the git directory?
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: what is the test target of t9400-git-cvsserver-server.sh
2010-07-03 20:52 ` Ævar Arnfjörð Bjarmason
@ 2010-07-03 21:28 ` Áshin László
0 siblings, 0 replies; 3+ messages in thread
From: Áshin László @ 2010-07-03 21:28 UTC (permalink / raw)
To: Ævar Arnfjörð Bjarmason; +Cc: git
You are right, I don't know why it didn't work for me when I first
tried. Now it does...
On Sat, Jul 3, 2010 at 22:52, Ævar Arnfjörð Bjarmason <avarab@gmail.com> wrote:
> On Sat, Jul 3, 2010 at 17:04, Áshin László <ashinlaszlo@gmail.com> wrote:
>> t9400-git-cvsserver-server.sh refers to git-cvsserver as CVS_SERVER
>> for the cvs client:
>> CVS_SERVER=git-cvsserver
>>
>> What is the goal of this test? To test the git-cvsserver executable
>> found in the system (in $PATH), or the one bundled in the git source
>> distribution? I would think that unit tests are to be run before make
>> install, so it should test the latter. I have a patch already to fix
>> that and I will post it in case I am right.
>
> Have you noticed that test-lib.sh sets PATH to include the git directory?
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-07-03 21:28 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-07-03 17:04 what is the test target of t9400-git-cvsserver-server.sh Áshin László
2010-07-03 20:52 ` Ævar Arnfjörð Bjarmason
2010-07-03 21:28 ` Áshin László
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).