From: Tay Ray Chuan <rctay89@gmail.com>
To: Jonathan Nieder <jrnieder@gmail.com>
Cc: Git Mailing List <git@vger.kernel.org>,
Junio C Hamano <gitster@pobox.com>, Jeff King <peff@peff.net>
Subject: Re: [RFC PATCH] GIT-VERSION-GEN: restrict tags used
Date: Wed, 12 May 2010 11:23:02 +0800 [thread overview]
Message-ID: <AANLkTim8SRUEaNWyBF_iRQstu84r9eAaUd0a9KLj6OtR@mail.gmail.com> (raw)
In-Reply-To: <20100511230100.GB31163@progeny.tock>
On Wed, May 12, 2010 at 7:01 AM, Jonathan Nieder <jrnieder@gmail.com> wrote:
> Tay Ray Chuan wrote:
>> This is to avoid using private tags by the user in a clone of the git
>> code repository, which may break certain machinery (eg. Makefile).
>
> Not to mention gitk:
>
> set git_version [join [lrange [split [lindex [exec git version] end] .] 0 2] .]
> if {[package vcompare $git_version "1.6.1"] >= 0} {
>
> This requires ‘git version’ output to have the form
>
> introducing 1.2.3.otherstuff
>
> or there will be errors at startup time.
Thanks for the heads-up, I'll put that in the patch message.
>> After this patch, perhaps we could advertise somewhere to git hackers
>> that tags beginning with "v" should be avoided.
>
> Maybe v[0-9]* would make this problem harder to trip.
Oh, I didn't know character classes were allows. Sounds good.
--
Cheers,
Ray Chuan
next prev parent reply other threads:[~2010-05-12 3:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-11 17:33 [RFC PATCH] GIT-VERSION-GEN: restrict tags used Tay Ray Chuan
2010-05-11 23:01 ` Jonathan Nieder
2010-05-11 23:05 ` Jonathan Nieder
2010-05-12 3:23 ` Tay Ray Chuan [this message]
2010-05-12 3:29 ` [PATCH] " Tay Ray Chuan
2010-05-12 5:54 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AANLkTim8SRUEaNWyBF_iRQstu84r9eAaUd0a9KLj6OtR@mail.gmail.com \
--to=rctay89@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jrnieder@gmail.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).