From: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
To: Thomas Rast <trast@student.ethz.ch>
Cc: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH 2/6] Makefile: Include subdirectories in "make cover" reports
Date: Sat, 24 Jul 2010 23:28:02 +0000 [thread overview]
Message-ID: <AANLkTim8UIiplPxUdcEWnDpevOUUZARgObhIFCkfO3zl@mail.gmail.com> (raw)
In-Reply-To: <201007250037.57086.trast@student.ethz.ch>
On Sat, Jul 24, 2010 at 22:37, Thomas Rast <trast@student.ethz.ch> wrote:
> Ævar Arnfjörð Bjarmason wrote:
>> The buildin/, xdiff/ and compat/ subdirectories weren't being included
>> in the gcov aggregation, nor were the files there being cleaned up.
> [...]
>> coverage-clean:
>> - rm -f *.gcda *.gcno
>> + $(RM) *.gcov *.gcda *.gcno
>> + $(RM) builtin/*.gcov
>> + $(RM) builtin/*.gcda
>> + $(RM) builtin/*.gcno
>
> By the same logic, the xdiff and compat directories should also be
> included here. Maybe also block-sha1?
Yeah, actually now that I think about it any C code we compile could
spew those *.gcda *.gcno files, which means:
$ find . -type f -name '*.c'| ack '^(.*/.*)/[^/]+$' --output '$1'|sort|uniq
./block-sha1
./builtin
./compat
./compat/fnmatch
./compat/nedmalloc
./compat/regex
./compat/win32
./contrib/convert-objects
./contrib/examples
./contrib/svn-fe
./ppc
./xdiff
Maybe it would be better to just put:
*.gcda
*.gcno
Into .gitignore, and leave it to the user to clean these with git
clean -dxf or something.
next prev parent reply other threads:[~2010-07-24 23:28 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-24 20:50 [PATCH 0/6] Detailed test coverage reports for Git Ævar Arnfjörð Bjarmason
2010-07-24 20:50 ` [PATCH 1/6] gitignore: Ignore files generated by "make coverage" Ævar Arnfjörð Bjarmason
2010-07-24 20:50 ` [PATCH 2/6] Makefile: Include subdirectories in "make cover" reports Ævar Arnfjörð Bjarmason
2010-07-24 22:37 ` Thomas Rast
2010-07-24 23:28 ` Ævar Arnfjörð Bjarmason [this message]
2010-07-24 23:41 ` Jonathan Nieder
2010-07-26 5:44 ` Junio C Hamano
2010-07-24 20:51 ` [PATCH 3/6] Makefile: Split out the untested functions target Ævar Arnfjörð Bjarmason
2010-07-24 23:02 ` Thomas Rast
2010-07-24 23:29 ` Ævar Arnfjörð Bjarmason
2010-07-24 20:51 ` [PATCH 4/6] Makefile: Add coverage-report-cover-db target Ævar Arnfjörð Bjarmason
2010-07-24 23:01 ` Thomas Rast
2010-07-24 23:28 ` Ævar Arnfjörð Bjarmason
2010-07-24 20:51 ` [PATCH 5/6] Makefile: Add coverage-report-cover-db-html target Ævar Arnfjörð Bjarmason
2010-07-24 20:51 ` [PATCH 6/6] t/README: A new section about test coverage Ævar Arnfjörð Bjarmason
2010-07-24 21:25 ` Jonathan Nieder
2010-07-24 21:29 ` Jonathan Nieder
2010-07-24 23:17 ` Ævar Arnfjörð Bjarmason
2010-07-24 23:32 ` Jonathan Nieder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AANLkTim8UIiplPxUdcEWnDpevOUUZARgObhIFCkfO3zl@mail.gmail.com \
--to=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=trast@student.ethz.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).