From: Greg Brockman <gdb@MIT.EDU>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] shell: Display errors from improperly-formatted command lines
Date: Fri, 27 Aug 2010 13:32:05 -0400 [thread overview]
Message-ID: <AANLkTim9Dbqt2Bs5F-PMYFrAwo4mAL6iVxmvYX1x4UYE@mail.gmail.com> (raw)
In-Reply-To: <7vlj7shsn5.fsf@alter.siamese.dyndns.org>
>> shell.c | 16 +++++++++++++---
>> 1 files changed, 13 insertions(+), 3 deletions(-)
>
> Forgot to sign-off?
Yes, sorry:
Signed-off-by: Greg Brockman <gdb@mit.edu>
>> The error behavior of split_cmdline was changed in the patch 'split_cmdline: Allow
>> caller to access error string'. This updates git-shell to deal with printing out
>> split_cmdline errors itself.
>
> Thanks for being careful. I'll merge gb/split-cmdline-errmsg topic (which
> already is in master) to gb/shell-ext topic (which is cooking in next) and
> then apply this on top. With this update I suppose the topic is ready to
> be in the next release?
Yep, I believe it's ready.
Thanks,
Greg
prev parent reply other threads:[~2010-08-27 17:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-27 5:36 [PATCH] shell: Display errors from improperly-formatted command lines Greg Brockman
2010-08-27 17:28 ` Junio C Hamano
2010-08-27 17:32 ` Greg Brockman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AANLkTim9Dbqt2Bs5F-PMYFrAwo4mAL6iVxmvYX1x4UYE@mail.gmail.com \
--to=gdb@mit.edu \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).