git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Karl Wiberg <kha@treskal.com>
To: "Gustav Hållberg" <gustav@gmail.com>
Cc: git@vger.kernel.org, catalin.marinas@gmail.com, davidk@lysator.liu.se
Subject: Re: [StGit PATCH] edit: Allow setting git tree SHA1 of a patch
Date: Mon, 17 May 2010 19:14:37 +0200	[thread overview]
Message-ID: <AANLkTimBSc35cnmRgDMDhQKtXC2PchcrSGHxMBcBMtuG@mail.gmail.com> (raw)
In-Reply-To: <20100516172738.5043.94039.stgit@localhost.localdomain>

2010/5/16 Gustav Hållberg <gustav@gmail.com>:
> I would like to have something similar to this patch, which allows for
> setting the (git) tree of a particular patch. I would like to use it
> (from the Emacs mode) to make it easier to split an old patch into two
> (or more).
>
> It might be that this is too "powerful" (read: unsafe), and maybe a
> better (safer) command would use whatever is currently in the index
> rather than a SHA1.

I think this is a reasonable idea. (Note that for unapplied
patches---or any patch that we can pop---the notion of setting the
bottom tree makes sense too. pick can currently create a patch from a
given commit; it might be reasonable to teach it (or stg new) to take
two trees instead.)

-- 
Karl Wiberg, kha@treskal.com
   subrabbit.wordpress.com
   www.treskal.com/kalle

  reply	other threads:[~2010-05-17 17:46 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-05-16 17:33 [StGit PATCH] edit: Allow setting git tree SHA1 of a patch Gustav Hållberg
2010-05-17 17:14 ` Karl Wiberg [this message]
2010-05-21 12:37 ` Catalin Marinas
2010-05-21 13:59   ` David Kågedal
2010-05-21 15:16     ` Catalin Marinas
2010-05-21 15:29       ` David Kågedal
2010-05-21 15:32       ` Gustav Hållberg
2010-05-21 15:58         ` Catalin Marinas
2010-05-21 17:48           ` David Kågedal
2010-05-21 18:45           ` Gustav Hållberg
2010-05-24 18:52           ` [PATCH 0/2] Setting git tree of a patch (improved version) Gustav Hållberg
2010-05-24 18:52             ` [PATCH 1/2] Repository.rev_parse: support commits, trees, and blobs Gustav Hållberg
2010-05-24 18:52             ` [PATCH 2/2] edit: Allow setting git tree of a patch Gustav Hållberg
2010-05-25 12:26             ` [PATCH 0/2] Setting git tree of a patch (improved version) Catalin Marinas
2010-05-26 15:34               ` Gustav Hållberg
2010-05-26 21:18                 ` Catalin Marinas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=AANLkTimBSc35cnmRgDMDhQKtXC2PchcrSGHxMBcBMtuG@mail.gmail.com \
    --to=kha@treskal.com \
    --cc=catalin.marinas@gmail.com \
    --cc=davidk@lysator.liu.se \
    --cc=git@vger.kernel.org \
    --cc=gustav@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).