From: Elijah Newren <newren@gmail.com>
To: Joshua Jensen <jjensen@workspacewhiz.com>
Cc: Dave Olszewski <cxreg@pobox.com>,
"git@vger.kernel.org" <git@vger.kernel.org>
Subject: Re: git pull --rebase differs in behavior from git fetch + git rebase
Date: Fri, 27 Aug 2010 17:40:21 -0600 [thread overview]
Message-ID: <AANLkTimBv3EVWaEnateD95sUi_LkmNw8RKJZYrW4dUFy@mail.gmail.com> (raw)
In-Reply-To: <4C783C66.3000008@workspacewhiz.com>
On Fri, Aug 27, 2010 at 4:29 PM, Joshua Jensen
<jjensen@workspacewhiz.com> wrote:
> It reports to me 'git-rebase --onto XXXX XXXX'.
>
> And it reports nothing to do.
>
> XXXX is properly the origin/master in this case.
>
> git rebase origin/master works.
> git rebase --onto origin/master origin/master does not work.
>
> Thoughts?
It's too bad you can't make this repository public; I thought rebase
should behave the same for those two commands. We could certainly
just modify git-pull.sh to avoid using the --onto flag when
oldremoteref is not defined (and perhaps that makes sense independent
of anything else), but I'm curious now about rebase.
Can you insert an echo statement right before where git-rebase calls
format-patch to see what arguments it is passing in those two cases?
For me it's around line 568; insert an echo statement so that it looks
like:
if test -z "$do_merge"
then
echo git format-patch -k --stdout --full-index --ignore-if-in-upstream \
--no-renames $root_flag "$revisions"
git format-patch -k --stdout --full-index --ignore-if-in-upstream \
--no-renames $root_flag "$revisions" |
git am $git_am_opt --rebasing --resolvemsg="$RESOLVEMSG" &&
Make that change, and then run it with both your rebase commands and
see what you get.
For me, in both cases, I get:
git format-patch ... --no-renames origin/master..HEAD
(except sha1sums of what origin/master and HEAD were rather than that
literal text), which means the same patches are being applied in both
cases for me.
Elijah
next prev parent reply other threads:[~2010-08-27 23:40 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-27 2:59 git pull --rebase differs in behavior from git fetch + git rebase Joshua Jensen
2010-08-27 7:23 ` Santi Béjar
2010-08-27 8:27 ` Dave Olszewski
2010-08-27 15:48 ` Joshua Jensen
2010-08-27 18:46 ` Elijah Newren
2010-08-27 22:29 ` Joshua Jensen
2010-08-27 23:40 ` Elijah Newren [this message]
2010-08-28 2:06 ` Joshua Jensen
2010-08-28 2:40 ` Elijah Newren
2010-08-28 3:13 ` Joshua Jensen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AANLkTimBv3EVWaEnateD95sUi_LkmNw8RKJZYrW4dUFy@mail.gmail.com \
--to=newren@gmail.com \
--cc=cxreg@pobox.com \
--cc=git@vger.kernel.org \
--cc=jjensen@workspacewhiz.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).