git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Piotr Krukowiecki <piotr.krukowiecki@gmail.com>
To: Johannes Sixt <j.sixt@viscovery.net>
Cc: Junio C Hamano <gitster@pobox.com>,
	Git Mailing List <git@vger.kernel.org>
Subject: Re: cherry-pick applies some other changes than the specified one?
Date: Tue, 22 Mar 2011 09:04:34 +0100	[thread overview]
Message-ID: <AANLkTimHEHQzV4B7beraEuT9Ta8+MBeyPPmSGkBWD+76@mail.gmail.com> (raw)
In-Reply-To: <4D879516.3060204@gmail.com>

On Mon, Mar 21, 2011 at 7:12 PM, Piotr Krukowiecki
<piotr.krukowiecki@gmail.com> wrote:
> W dniu 21.03.2011 17:41, Johannes Sixt pisze:
>> Assuming you did not 'git add' the file yet, you are looking at the
>> "condensed combined diff" after manually resolving the conflict by doing
>> the "+line" manually that the cherry-pick should have brought in. Of
>> course, a lot of context is visible here if both sides have diverged
>> considerably in this area.
>>
>> I.e. the diff will look something like
>>
>>  +line from HEAD
>>  +line from HEAD
>> + line from cherry-picked
>>  +line from HEAD
>> ...
>>
>> Notice the double columns before the content lines. This sort of diff
>> extens above and below the conflicting section until there is a "gap" of 3
>> lines that changed neither on the HEAD side nor on the cherry-picked side
>> since the merge base.
>
> Hm that might be possible! I'll check it tomorrow @work.

You were right - the line I've added manually have two "++", and the other
lines shown with differences only have "-" and "+" in the second column.

I'm still not clear what is exactly compared when I use plain diff or
-c version.
It might be I need to read more docs. I'll ask if I'm still in doubt
after reading
more.

Thanks again for explaining this to me - saved me from a lot of PITA researching
:)


-- 
Piotr Krukowiecki

      parent reply	other threads:[~2011-03-22  8:04 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-21  9:27 cherry-pick applies some other changes than the specified one? Piotr Krukowiecki
2011-03-21 16:09 ` Junio C Hamano
2011-03-21 16:41   ` Johannes Sixt
2011-03-21 18:12     ` Piotr Krukowiecki
2011-03-21 19:47       ` Junio C Hamano
2011-03-21 20:06         ` Piotr Krukowiecki
2011-03-21 19:58       ` Jonathan Nieder
2011-03-21 20:07         ` Piotr Krukowiecki
2011-03-21 20:21           ` Junio C Hamano
2011-03-21 20:54             ` Junio C Hamano
2011-03-22  5:27               ` Jonathan Nieder
2011-03-22  6:37                 ` Junio C Hamano
2011-03-22  8:04       ` Piotr Krukowiecki [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=AANLkTimHEHQzV4B7beraEuT9Ta8+MBeyPPmSGkBWD+76@mail.gmail.com \
    --to=piotr.krukowiecki@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=j.sixt@viscovery.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).