From: Andrew Garber <andrew@andrewgarber.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] git-p4: correct indenting and formatting
Date: Wed, 12 Jan 2011 01:13:42 -0800 [thread overview]
Message-ID: <AANLkTimJOsRd4WcDSJZcehP3nn_rckL4hx4ngt48w9gD@mail.gmail.com> (raw)
In-Reply-To: <7vhbde331h.fsf@alter.siamese.dyndns.org>
Great! Thanks Junio. Sorry about forgetting to sign-off my patch.
On Wed, Jan 12, 2011 at 1:05 AM, Junio C Hamano <gitster@pobox.com> wrote:
> Junio C Hamano <gitster@pobox.com> writes:
>
>> Junio C Hamano <gitster@pobox.com> writes:
>>
>>> Andrew Garber <andrew@andrewgarber.com> writes:
>>>
>>>> - replace tabs with appropriate number of spaces
>>>> - minor tweaks to code formatting
>>>> ---
>>>> contrib/fast-import/git-p4 | 71 +++++++++++++++++++++-----------------------
>>>> 1 files changed, 34 insertions(+), 37 deletions(-)
>>> ...
>> Will queue on a separate branch for you, expecting that you are doing this
>> in preparation for a new feature or a bugfix to the script.
>
> Forgot to say obligatory "Please sign-off your patch". Please do so.
>
prev parent reply other threads:[~2011-01-12 9:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-12 5:05 [PATCH] git-p4: correct indenting and formatting Andrew Garber
2011-01-12 8:45 ` Junio C Hamano
2011-01-12 9:04 ` Junio C Hamano
2011-01-12 9:05 ` Junio C Hamano
2011-01-12 9:13 ` Andrew Garber [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AANLkTimJOsRd4WcDSJZcehP3nn_rckL4hx4ngt48w9gD@mail.gmail.com \
--to=andrew@andrewgarber.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).