From: Erik Faye-Lund <kusmabite@gmail.com>
To: rkitover@io.com
Cc: git@vger.kernel.org
Subject: Re: [PATCH] more portable absolute dir check in Git.pm
Date: Sun, 6 Feb 2011 23:32:55 +0100 [thread overview]
Message-ID: <AANLkTimLCnYYv74NMumXHOdWuNBt3ontLo4v-Ey_0kay@mail.gmail.com> (raw)
In-Reply-To: <4D4D7890.3020906@io.com>
On Sat, Feb 5, 2011 at 5:19 PM, Rafael Kitover <rkitover@io.com> wrote:
> I was trying to get msysGit to work with activeperl. I'm not sure how far I
> got, I will revisit this problem in the future, but here is a patch.
>
> It removes a problematic make fragment that doesn't work on nmake (and
> probably dmake as well.) As well as a better absolute dir check in Git.pm .
>
Please read Documentation/SubmittingPatches. In particlar:
- We use inline patches on the mailing-list. git send-email can send
these for you.
- Your patch lacks a sign-off.
Other than that, interesting. But I think the make_frag-changes needs
an explanation.
prev parent reply other threads:[~2011-02-06 22:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-05 16:19 [PATCH] more portable absolute dir check in Git.pm Rafael Kitover
2011-02-06 22:32 ` Erik Faye-Lund [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AANLkTimLCnYYv74NMumXHOdWuNBt3ontLo4v-Ey_0kay@mail.gmail.com \
--to=kusmabite@gmail.com \
--cc=git@vger.kernel.org \
--cc=rkitover@io.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).